Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4365)

Unified Diff: chrome/browser/resource_coordinator/tab_manager.h

Issue 2935183002: [TabMetrics] Add signals that mark the start and end of session restore. (Closed)
Patch Set: Enable SessionRestoreObserverTest only when session service available. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resource_coordinator/tab_manager.h
diff --git a/chrome/browser/resource_coordinator/tab_manager.h b/chrome/browser/resource_coordinator/tab_manager.h
index 3cd08c9805cdf1b94d247b258eccbf52a03d346f..414b743c8426e5c474210a5a3600db6db3841f95 100644
--- a/chrome/browser/resource_coordinator/tab_manager.h
+++ b/chrome/browser/resource_coordinator/tab_manager.h
@@ -24,6 +24,7 @@
#include "build/build_config.h"
#include "chrome/browser/resource_coordinator/tab_manager_observer.h"
#include "chrome/browser/resource_coordinator/tab_stats.h"
+#include "chrome/browser/sessions/session_restore_observer.h"
#include "chrome/browser/ui/browser_tab_strip_tracker.h"
#include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
#include "ui/gfx/geometry/rect.h"
@@ -156,6 +157,11 @@ class TabManager : public TabStripModelObserver {
// the WebContents could be deleted if the user closed the tab.
static int64_t IdFromWebContents(content::WebContents* web_contents);
+ // Return whether tabs are being loaded during session restore.
+ bool IsSessionRestoreLoadingTabs() const {
+ return is_session_restore_loading_tabs_;
+ }
+
private:
FRIEND_TEST_ALL_PREFIXES(TabManagerTest, PurgeBackgroundRenderer);
FRIEND_TEST_ALL_PREFIXES(TabManagerTest, ActivateTabResetPurgeState);
@@ -321,6 +327,9 @@ class TabManager : public TabStripModelObserver {
// list is constructed from either |test_browser_info_list_| or BrowserList.
std::vector<BrowserInfo> GetBrowserInfoList() const;
+ void OnSessionRestoreStartedLoadingTabs();
+ void OnSessionRestoreFinishedLoadingTabs();
+
// Timer to periodically update the stats of the renderers.
base::RepeatingTimer update_timer_;
@@ -383,6 +392,11 @@ class TabManager : public TabStripModelObserver {
// List of observers that will receive notifications on state changes.
base::ObserverList<TabManagerObserver> observers_;
+ bool is_session_restore_loading_tabs_;
+
+ class TabManagerSessionRestoreObserver;
+ std::unique_ptr<TabManagerSessionRestoreObserver> session_restore_observer_;
+
// Weak pointer factory used for posting delayed tasks.
base::WeakPtrFactory<TabManager> weak_ptr_factory_;
« no previous file with comments | « no previous file | chrome/browser/resource_coordinator/tab_manager.cc » ('j') | chrome/browser/sessions/session_restore.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698