Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3155)

Unified Diff: chrome/browser/sessions/tab_loader.cc

Issue 2935183002: [TabMetrics] Add signals that mark the start and end of session restore. (Closed)
Patch Set: Store global SessionRestoreObserver list into a separate class. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/tab_loader.cc
diff --git a/chrome/browser/sessions/tab_loader.cc b/chrome/browser/sessions/tab_loader.cc
index 753f4e0493c23ad66dc15e7f1f37a6574ce3f7e1..42377ac01d8500b7cd07cbb2050892adb8d98ebb 100644
--- a/chrome/browser/sessions/tab_loader.cc
+++ b/chrome/browser/sessions/tab_loader.cc
@@ -13,6 +13,7 @@
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "build/build_config.h"
+#include "chrome/browser/sessions/session_restore_observer.h"
#include "chrome/browser/sessions/session_restore_stats_collector.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
@@ -103,6 +104,8 @@ TabLoader::TabLoader(base::TimeTicks restore_started)
shared_tab_loader_ = this;
this_retainer_ = this;
base::MemoryCoordinatorClientRegistry::GetInstance()->Register(this);
+ for (auto* observer : *SessionRestoreObserver::observers())
lpy 2017/06/23 22:35:57 Once use base::ObserverList, this should be auto&
ducbui 2017/06/23 23:30:15 Done.
+ observer->OnTabLoadingStarted();
}
TabLoader::~TabLoader() {
@@ -110,6 +113,8 @@ TabLoader::~TabLoader() {
DCHECK(shared_tab_loader_ == this);
shared_tab_loader_ = nullptr;
base::MemoryCoordinatorClientRegistry::GetInstance()->Unregister(this);
+ for (auto* observer : *SessionRestoreObserver::observers())
+ observer->OnTabLoadingEnded();
}
void TabLoader::StartLoading(const std::vector<RestoredTab>& tabs) {

Powered by Google App Engine
This is Rietveld 408576698