chrome/browser/sessions/session_restore_observer.h - Issue 2935183002: [TabMetrics] Add signals that mark the start and end of session restore.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/sessions/session_restore_observer.h

Issue 2935183002: [TabMetrics] Add signals that mark the start and end of session restore. (Closed)

Patch Set: Address new comments. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SESSIONS_SESSION_RESTORE_OBSERVER_H_

	6 #define CHROME_BROWSER_SESSIONS_SESSION_RESTORE_OBSERVER_H_

	7

	8 // Observer of events during session restore.

	9 class SessionRestoreObserver {

	10 public:

	11 // OnSessionRestoreStartedLoadingTabs is triggered when the browser starts

	12 // loading tabs in session restore.

	13 virtual void OnSessionRestoreStartedLoadingTabs() {}

	14

	15 // OnSessionRestoreFinishedLoadingTabs is triggered when the browser finishes

	16 // loading tabs in session restore.
	sky 2017/06/27 00:11:53 Please also document that in the case of memory pr Please also document that in the case of memory pressure not all WebContents may have been created. ducbui 2017/06/27 00:45:03 Done. Show quoted text On 2017/06/27 00:11:53, sky wrote: > Please also document that in the case of memory pressure not all WebContents may > have been created. Done.
	17 virtual void OnSessionRestoreFinishedLoadingTabs() {}

	18 };

	19

	20 #endif // CHROME_BROWSER_SESSIONS_SESSION_RESTORE_OBSERVER_H_

OLD	NEW