chrome/browser/sessions/session_restore_observer.h - Issue 2935183002: [TabMetrics] Add signals that mark the start and end of session restore.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/sessions/session_restore_observer.h

Issue 2935183002: [TabMetrics] Add signals that mark the start and end of session restore. (Closed)

Patch Set: Store global SessionRestoreObserver list into a separate class. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resource_coordinator/tab_manager.cc ('K') | « chrome/browser/resource_coordinator/tab_manager_unittest.cc ('k') | chrome/browser/sessions/session_restore_observer.cc » ('j') | chrome/browser/sessions/tab_loader.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SESSIONS_SESSION_RESTORE_OBSERVER_H_

	6 #define CHROME_BROWSER_SESSIONS_SESSION_RESTORE_OBSERVER_H_

	7

	8 #include <unordered_set>

	9

	10 // Observer of events during session restore.

	11 // The set of observers will be deleted when there is no observer.

	12 class SessionRestoreObserver {

	13 public:

	14 virtual void OnTabLoadingStarted() {}

	15 virtual void OnTabLoadingEnded() {}

	16

	17 static std::unordered_set<SessionRestoreObserver> observers();
	lpy 2017/06/23 22:35:57 Let's use static base::ObserverList<SessionRestore Let's use static base::ObserverList<SessionRestoreObserver>& observers(); ducbui 2017/06/23 23:30:14 Done. Show quoted text On 2017/06/23 22:35:57, lpy wrote: > Let's use static base::ObserverList<SessionRestoreObserver>& observers(); Done.
	18

	19 static void AddObserver(SessionRestoreObserver* observer);

	20 static void RemoveObserver(SessionRestoreObserver* observer);

	21

	22 private:

	23 static std::unordered_set<SessionRestoreObserver> observers_;
	lpy 2017/06/23 22:35:57 Let's use base::ObserverList<SessionRestoreObserve Let's use base::ObserverList<SessionRestoreObserver>* ducbui 2017/06/23 23:30:14 Done. Show quoted text On 2017/06/23 22:35:57, lpy wrote: > Let's use base::ObserverList<SessionRestoreObserver>* Done.
	24 };

	25

	26 #endif // CHROME_BROWSER_SESSIONS_SESSION_RESTORE_OBSERVER_H_

OLD	NEW