Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2935063002: Add ClosedWorld.elementEnvironment and remove Compiler.elementEnvironment (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add ClosedWorld.elementEnvironment and remove Compiler.elementEnvironment R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/ea070c7264a21dbb75b90079f5f40a9b440041d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -66 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 7 chunks +10 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 13 chunks +32 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/element_strategy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_model/elements.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 6 chunks +9 lines, -3 lines 0 comments Download
M pkg/compiler/tool/perf.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/dill_loader_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/inference/inference_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/no_such_method_enabled_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-13 14:34:44 UTC) #2
Emily Fortuna
lgtm
3 years, 6 months ago (2017-06-13 17:47:43 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-14 08:27:47 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ea070c7264a21dbb75b90079f5f40a9b440041d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698