Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3526)

Unified Diff: chrome/browser/google/google_url_tracker_navigation_helper_impl.cc

Issue 293503003: Eliminate dependence of GoogleURLTracker et al. on InfoBarService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google/google_url_tracker_navigation_helper_impl.cc
diff --git a/chrome/browser/google/google_url_tracker_navigation_helper_impl.cc b/chrome/browser/google/google_url_tracker_navigation_helper_impl.cc
index 99420a86efaefc5bb10493f1cbcc5249767f0994..29bfd58302decb8c291c19d69ccf656e7e229e69 100644
--- a/chrome/browser/google/google_url_tracker_navigation_helper_impl.cc
+++ b/chrome/browser/google/google_url_tracker_navigation_helper_impl.cc
@@ -20,6 +20,7 @@ GoogleURLTrackerNavigationHelperImpl::GoogleURLTrackerNavigationHelperImpl(
}
GoogleURLTrackerNavigationHelperImpl::~GoogleURLTrackerNavigationHelperImpl() {
+ web_contents_ = NULL;
}
void GoogleURLTrackerNavigationHelperImpl::SetListeningForNavigationCommit(
@@ -67,6 +68,16 @@ bool GoogleURLTrackerNavigationHelperImpl::IsListeningForTabDestruction() {
content::Source<content::WebContents>(web_contents_));
}
+void GoogleURLTrackerNavigationHelperImpl::OpenURL(
+ GURL url,
+ WindowOpenDisposition disposition,
+ bool user_clicked_on_link) {
+ content::PageTransition transition_type = user_clicked_on_link ?
+ content::PAGE_TRANSITION_LINK : content::PAGE_TRANSITION_GENERATED;
+ web_contents_->OpenURL(content::OpenURLParams(
+ url, content::Referrer(), disposition, transition_type, false));
+}
+
void GoogleURLTrackerNavigationHelperImpl::Observe(
int type,
const content::NotificationSource& source,

Powered by Google App Engine
This is Rietveld 408576698