Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5115)

Unified Diff: chrome/browser/google/google_url_tracker_navigation_helper.h

Issue 293503003: Eliminate dependence of GoogleURLTracker et al. on InfoBarService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google/google_url_tracker_navigation_helper.h
diff --git a/chrome/browser/google/google_url_tracker_navigation_helper.h b/chrome/browser/google/google_url_tracker_navigation_helper.h
index 98804cebfd9ff946d3f2de27b8347f140cae8336..98b8b3a7bfe9d9b799e0f36bd3d796991e007da9 100644
--- a/chrome/browser/google/google_url_tracker_navigation_helper.h
+++ b/chrome/browser/google/google_url_tracker_navigation_helper.h
@@ -6,11 +6,14 @@
#define CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_NAVIGATION_HELPER_H_
#include "base/macros.h"
+#include "ui/base/window_open_disposition.h"
class GoogleURLTracker;
+class GURL;
-// A helper class for GoogleURLTracker that abstracts the details of listening
-// for various navigation events.
+// Interface via which GoogleURLTracker communicates with its driver.
+// TODO(blundell): Rename this class to GoogleURLTrackerDriver.
+// crbug.com/373221
class GoogleURLTrackerNavigationHelper {
public:
explicit GoogleURLTrackerNavigationHelper(
@@ -34,6 +37,11 @@ class GoogleURLTrackerNavigationHelper {
// destruction.
virtual bool IsListeningForTabDestruction() = 0;
+ // Opens |url| with the given window disposition.
+ virtual void OpenURL(GURL url,
+ WindowOpenDisposition disposition,
+ bool user_clicked_on_link) = 0;
+
protected:
GoogleURLTracker* google_url_tracker() { return google_url_tracker_; }

Powered by Google App Engine
This is Rietveld 408576698