chrome/browser/google/google_url_tracker_navigation_helper_impl.h - Issue 293503003: Eliminate dependence of GoogleURLTracker et al. on InfoBarService

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/google/google_url_tracker_navigation_helper_impl.h

Issue 293503003: Eliminate dependence of GoogleURLTracker et al. on InfoBarService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Response to review Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/google/google_url_tracker_navigation_helper.h ('k') | chrome/browser/google/google_url_tracker_navigation_helper_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_NAVIGATION_HELPER_IMPL_H_	5 #ifndef CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_NAVIGATION_HELPER_IMPL_H_

6 #define CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_NAVIGATION_HELPER_IMPL_H_	6 #define CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_NAVIGATION_HELPER_IMPL_H_

7	7

8 #include "chrome/browser/google/google_url_tracker_navigation_helper.h"	8 #include "chrome/browser/google/google_url_tracker_navigation_helper.h"

9 #include "content/public/browser/notification_observer.h"	9 #include "content/public/browser/notification_observer.h"

10 #include "content/public/browser/notification_registrar.h"	10 #include "content/public/browser/notification_registrar.h"

(...skipping 11 matching lines...) Expand all Loading...
22 GoogleURLTracker* tracker);	22 GoogleURLTracker* tracker);

23 virtual ~GoogleURLTrackerNavigationHelperImpl();	23 virtual ~GoogleURLTrackerNavigationHelperImpl();

24	24

25 // GoogleURLTrackerNavigationHelper:	25 // GoogleURLTrackerNavigationHelper:

26 virtual void SetListeningForNavigationCommit(	26 virtual void SetListeningForNavigationCommit(

27 bool listen) OVERRIDE;	27 bool listen) OVERRIDE;

28 virtual bool IsListeningForNavigationCommit() OVERRIDE;	28 virtual bool IsListeningForNavigationCommit() OVERRIDE;

29 virtual void SetListeningForTabDestruction(	29 virtual void SetListeningForTabDestruction(

30 bool listen) OVERRIDE;	30 bool listen) OVERRIDE;

31 virtual bool IsListeningForTabDestruction() OVERRIDE;	31 virtual bool IsListeningForTabDestruction() OVERRIDE;

	32 virtual void OpenURL(GURL url,

	33 WindowOpenDisposition disposition,

	34 bool user_clicked_on_link) OVERRIDE;

32	35

33 private:	36 private:

34 // content::NotificationObserver:	37 // content::NotificationObserver:

35 virtual void Observe(int type,	38 virtual void Observe(int type,

36 const content::NotificationSource& source,	39 const content::NotificationSource& source,

37 const content::NotificationDetails& details) OVERRIDE;	40 const content::NotificationDetails& details) OVERRIDE;

38	41

39 content::WebContents* web_contents_;	42 content::WebContents* web_contents_;

40 content::NotificationRegistrar registrar_;	43 content::NotificationRegistrar registrar_;

41	44

42 DISALLOW_COPY_AND_ASSIGN(GoogleURLTrackerNavigationHelperImpl);	45 DISALLOW_COPY_AND_ASSIGN(GoogleURLTrackerNavigationHelperImpl);

43 };	46 };

44	47

45 #endif // CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_NAVIGATION_HELPER_IMPL_H_	48 #endif // CHROME_BROWSER_GOOGLE_GOOGLE_URL_TRACKER_NAVIGATION_HELPER_IMPL_H_

OLD	NEW