Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: chrome/browser/resources/options/options_page.js

Issue 2935011: Initial accounts options page. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: use ListItem directly for now per arv Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/options_page.css ('k') | chrome/browser/resources/options/preferences.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/options_page.js
diff --git a/chrome/browser/resources/options/options_page.js b/chrome/browser/resources/options/options_page.js
index 50cff738527afee7526aebf153c48a2039c2ffef..9550031a8662ad19728e4a773bba07b269b7f90c 100644
--- a/chrome/browser/resources/options/options_page.js
+++ b/chrome/browser/resources/options/options_page.js
@@ -12,6 +12,7 @@
* containing the options view and the name of options page navigation bar
* item as name+'PageNav'.
* @param {string} title Options page title, used for navigation bar
+ * @extends {EventTarget}
*/
function OptionsPage(name, title, pageDivName) {
this.name = name;
@@ -121,6 +122,8 @@ OptionsPage.initialize = function() {
};
OptionsPage.prototype = {
+ __proto__: cr.EventTarget.prototype,
+
/**
* Initializes page content.
*/
@@ -150,7 +153,6 @@ OptionsPage.prototype = {
if (this.isOverlay) {
var overlay = $('overlay');
overlay.classList.remove('hidden');
- overlay.classList.add('overlay-visible');
}
if (this.tab) {
this.tab.classList.add('navbar-item-selected');
@@ -161,7 +163,6 @@ OptionsPage.prototype = {
if (this.isOverlay) {
var overlay = $('overlay');
overlay.classList.add('hidden');
- overlay.classList.remove('overlay-visible');
}
this.pageDiv.style.display = 'none';
if (this.tab) {
@@ -170,5 +171,7 @@ OptionsPage.prototype = {
this.tab.classList.add('hidden');
}
}
+
+ cr.dispatchPropertyChange(this, 'visible', visible, !visible);
}
};
« no previous file with comments | « chrome/browser/resources/options/options_page.css ('k') | chrome/browser/resources/options/preferences.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698