ui/views/controls/textfield/textfield.cc - Issue 2934993002: MacViews a11y: Allow VoiceOver to read out views::Label word-by-word.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 2934993002: MacViews a11y: Allow VoiceOver to read out views::Label word-by-word. (Closed)

Patch Set: Fix TextfieldTest.AccessiblePasswordTest Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/textfield/textfield.cc

diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc

index 708921603b8864092626c4f890f1284da8d0e4cb..1dd4dec9407a1a96b786a28a993744d3ef30442e 100644

--- a/ui/views/controls/textfield/textfield.cc

+++ b/ui/views/controls/textfield/textfield.cc

@@ -926,7 +926,8 @@ void Textfield::GetAccessibleNodeData(ui::AXNodeData* node_data) {

node_data->AddState(ui::AX_STATE_EDITABLE);

if (text_input_type_ == ui::TEXT_INPUT_TYPE_PASSWORD) {

node_data->AddState(ui::AX_STATE_PROTECTED);

- node_data->SetValue(base::string16(text().size(), '*'));

+ node_data->SetValue(base::string16(

+ text().size(), gfx::RenderText::kPasswordReplacementChar));

} else {

node_data->SetValue(text());

}