Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: remoting/host/audio_capturer_win.cc

Issue 2934983002: [Chromoting] Update comments in AudioCapturerWin (Closed)
Patch Set: Resolve review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/audio_capturer_win.cc
diff --git a/remoting/host/audio_capturer_win.cc b/remoting/host/audio_capturer_win.cc
index 3dd6dc7b7c1d2226e74742b425c1d661cd86b8c1..e47bb40329c829c6d6ed24a51716fd14541218bc 100644
--- a/remoting/host/audio_capturer_win.cc
+++ b/remoting/host/audio_capturer_win.cc
@@ -274,7 +274,9 @@ void AudioCapturerWin::DoCapture() {
packet->set_bytes_per_sample(AudioPacket::BYTES_PER_SAMPLE_2);
// Only the count of channels is taken into account now, we should also
// consider dwChannelMask.
- // TODO(zijiehe): Support also layouts.
+ // TODO(zijiehe): Convert dwChannelMask to layout and pass it to
+ // AudioPump. So the stream can be downmixed properly with both number and
+ // layouts of speakers.
packet->set_channels(static_cast<AudioPacket::Channels>(
wave_format_ex_->nChannels));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698