Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 2934973002: Address observatory analysis issues. (Closed)

Created:
3 years, 6 months ago by devoncarew
Modified:
3 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -71 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/isolate.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/async_next_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_exception_test.dart View 1 chunk +8 lines, -11 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_into_test.dart View 1 chunk +5 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/async_single_step_out_test.dart View 1 chunk +6 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/async_star_single_step_into_test.dart View 1 chunk +7 lines, -9 lines 0 comments Download
M runtime/observatory/tests/service/async_star_step_out_test.dart View 2 chunks +11 lines, -13 lines 0 comments Download
M runtime/observatory/tests/service/async_step_out_test.dart View 1 chunk +6 lines, -8 lines 0 comments Download
M runtime/observatory/tests/service/evaluate_in_frame_with_scope_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/evaluate_with_scope_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/observatory/tests/service/get_native_allocation_samples_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
devoncarew
Redux of https://codereview.chromium.org/2935873002/, with less magic around line number parsing.
3 years, 6 months ago (2017-06-12 23:23:36 UTC) #2
rmacnak
lgtm
3 years, 6 months ago (2017-06-12 23:58:18 UTC) #3
devoncarew
3 years, 6 months ago (2017-06-13 22:58:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9ec724cd6b90065d6d1554e403fd126cad9bc5b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698