Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2934933002: Build reverse dependencies between LibraryCycle(s). (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Build reverse dependencies between LibraryCycle(s). I plan using it for adding libraries that have not been affected by the changed files, but must be sent to VM because of possible inlining. We will find affected libraries and then climb up until we reach the entry point. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c4de2886b1cf5bd8a2be9863f4eb45de191b01b4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -7 lines) Patch
M pkg/front_end/lib/src/incremental/file_state.dart View 4 chunks +27 lines, -1 line 1 comment Download
M pkg/front_end/test/src/incremental/file_state_test.dart View 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 6 months ago (2017-06-12 21:29:59 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2934933002/diff/1/pkg/front_end/lib/src/incremental/file_state.dart File pkg/front_end/lib/src/incremental/file_state.dart (right): https://codereview.chromium.org/2934933002/diff/1/pkg/front_end/lib/src/incremental/file_state.dart#newcode567 pkg/front_end/lib/src/incremental/file_state.dart:567: // Build the set of cycles this cycles ...
3 years, 6 months ago (2017-06-12 22:19:45 UTC) #2
scheglov
3 years, 6 months ago (2017-06-13 00:30:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4de2886b1cf5bd8a2be9863f4eb45de191b01b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698