src/debug/debug-evaluate.cc - Issue 2934893002: [builtins] Properly optimize Object.prototype.isPrototypeOf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-evaluate.cc

Issue 2934893002: [builtins] Properly optimize Object.prototype.isPrototypeOf. (Closed)

Patch Set: Address feedback. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/debug-evaluate.cc

diff --git a/src/debug/debug-evaluate.cc b/src/debug/debug-evaluate.cc

index 03029b8235577c768c38e3b03dc4a9a29f3304fb..28348ec2fbaa9c3c47e2ae068631c5701f90f3e6 100644

--- a/src/debug/debug-evaluate.cc

+++ b/src/debug/debug-evaluate.cc

@@ -483,6 +483,7 @@ bool BuiltinHasNoSideEffect(Builtins::Name id) {

case Builtins::kObjectPrototypeValueOf:

case Builtins::kObjectValues:

case Builtins::kObjectHasOwnProperty:

+ case Builtins::kObjectPrototypeIsPrototypeOf:

case Builtins::kObjectPrototypePropertyIsEnumerable:

case Builtins::kObjectProtoToString:

// Array builtins.

« no previous file with comments | « src/compiler/verifier.cc ('k') | src/js/v8natives.js » ('j') | no next file with comments »