Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: ios/public/provider/chrome/browser/signin/chrome_identity_service.h

Issue 2934843002: Adds signin provider APIs that don't return scoped_nsobjects. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/public/provider/chrome/browser/signin/chrome_identity_service.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/public/provider/chrome/browser/signin/chrome_identity_service.h
diff --git a/ios/public/provider/chrome/browser/signin/chrome_identity_service.h b/ios/public/provider/chrome/browser/signin/chrome_identity_service.h
index fe675ce77dc3162a53823a9cbeda4498996f02e5..201bb61e4709ec54dac7aaf13513719ed3b48881 100644
--- a/ios/public/provider/chrome/browser/signin/chrome_identity_service.h
+++ b/ios/public/provider/chrome/browser/signin/chrome_identity_service.h
@@ -102,17 +102,36 @@ class ChromeIdentityService {
// Returns a new account details controller to present. A cancel button is
// present as leading navigation item.
- virtual base::scoped_nsobject<UINavigationController> NewAccountDetails(
+ virtual UINavigationController* CreateAccountDetailsController(
ChromeIdentity* identity,
id<ChromeIdentityBrowserOpener> browser_opener);
// Returns a new Web and App Setting Details controller to present.
+ virtual UINavigationController* CreateWebAndAppSettingDetailsController(
+ ChromeIdentity* identity,
+ id<ChromeIdentityBrowserOpener> browser_opener);
+
+ // Returns a new ChromeIdentityInteractionManager with |delegate| as its
+ // delegate.
+ virtual ChromeIdentityInteractionManager*
+ CreateChromeIdentityInteractionManager(
+ ios::ChromeBrowserState* browser_state,
+ id<ChromeIdentityInteractionManagerDelegate> delegate) const;
+
+ // Deprecated. Returns a new account details controller to present. A cancel
+ // button is present as leading navigation item.
+ virtual base::scoped_nsobject<UINavigationController> NewAccountDetails(
+ ChromeIdentity* identity,
+ id<ChromeIdentityBrowserOpener> browser_opener);
+
+ // Deprecated. Returns a new Web and App Setting Details controller to
+ // present.
virtual base::scoped_nsobject<UINavigationController>
NewWebAndAppSettingDetails(ChromeIdentity* identity,
id<ChromeIdentityBrowserOpener> browser_opener);
- // Returns a new ChromeIdentityInteractionManager with |delegate| as its
- // delegate.
+ // Deprecated. Returns a new ChromeIdentityInteractionManager with |delegate|
+ // as its delegate.
virtual base::scoped_nsobject<ChromeIdentityInteractionManager>
NewChromeIdentityInteractionManager(
ios::ChromeBrowserState* browser_state,
« no previous file with comments | « no previous file | ios/public/provider/chrome/browser/signin/chrome_identity_service.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698