appengine/config_service/projects.py - Issue 2934783004: config_service: use == for sentinel value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/config_service/projects.py

Issue 2934783004: config_service: use == for sentinel value (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/config_service/projects.py

diff --git a/appengine/config_service/projects.py b/appengine/config_service/projects.py

index 7b402b8eeaf1c6dbb884d0f974e978c67309c526..8cacefb8ab1c20d6c15ced83e5daf2d1c25b79b2 100644

--- a/appengine/config_service/projects.py

+++ b/appengine/config_service/projects.py

@@ -115,7 +115,7 @@ def get_metadata_async(project_ids):

binary = cache_futs[pid].get_result()

if binary is not None:

# cache hit

- if binary is PROJECT_DOES_NOT_EXIST_SENTINEL:

+ if binary == PROJECT_DOES_NOT_EXIST_SENTINEL:

result[pid] = None

else:

cfg = project_config_pb2.ProjectCfg()

« no previous file with comments | « no previous file | no next file » | no next file with comments »