Issue 2934763002: Re-validate command line options after changing them in fasta

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2934763002: Re-validate command line options after changing them in fasta (Closed)

Created:
3 years, 6 months ago by Dmitry Stefantsov

Modified:
3 years, 6 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Kevin Millikin (Google)

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	pkg/front_end/lib/src/fasta/fasta.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Dmitry Stefantsov

Some methods in fasta.dart change the instance of a CompilerCommandLine instance after it's validated. This ...

3 years, 6 months ago (2017-06-12 09:24:50 UTC) #2

Dmitry Stefantsov

3 years, 6 months ago (2017-06-12 09:30:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1c544012c361311c8cfccb44c3d25c63173c5c36 (presubmit successful).