Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 293473003: Oilpan: fix build after r174194. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: fix build after r174194. Fix compilation errors (unused variable warnings-as-errors) in AnimationTest.cpp R= BUG=340522 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/animation/AnimationTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sof
Please have a look. (I notice there are 3 unit test failures (Animation-related) with Oilpan ...
6 years, 7 months ago (2014-05-17 07:42:31 UTC) #1
tkent
lgtm
6 years, 7 months ago (2014-05-17 13:13:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/293473003/1
6 years, 7 months ago (2014-05-17 13:14:16 UTC) #3
haraken
LGTM, thanks!
6 years, 7 months ago (2014-05-17 19:15:47 UTC) #4
tkent
Some try bots didn't start. I'll add NOTRY=true and re-check CQ checkbox.
6 years, 7 months ago (2014-05-18 02:42:23 UTC) #5
tkent
The CQ bit was unchecked by tkent@chromium.org
6 years, 7 months ago (2014-05-18 02:42:39 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 7 months ago (2014-05-18 02:42:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/293473003/1
6 years, 7 months ago (2014-05-18 02:43:16 UTC) #8
commit-bot: I haz the power
Change committed as 174234
6 years, 7 months ago (2014-05-18 02:44:14 UTC) #9
sof
6 years, 7 months ago (2014-05-18 05:49:48 UTC) #10
Message was sent while issue was closed. 
thanks for doing that.

Powered by Google App Engine
This is Rietveld 408576698