Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

Issue 2934623003: fix #29753, use ES5 constructors for ddc (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
index d551ddc21a1e141cf06220356cf9625c07db1273..ef7f3a94cfa7907a3d2ac358254626479f9a58c0 100644
--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
@@ -234,9 +234,9 @@ _toDisplayName(name) => JS(
Symbol _dartSymbol(name) {
return (JS('bool', 'typeof # === "symbol"', name))
- ? JS('', '#(new #(#, #))', const_, _internal.PrivateSymbol,
+ ? JS('Symbol', '#(new #.new(#, #))', const_, _internal.PrivateSymbol,
_toSymbolName(name), name)
- : JS('', '#(#.new(#))', const_, Symbol, _toDisplayName(name));
+ : JS('Symbol', '#(#.new(#))', const_, Symbol, _toDisplayName(name));
}
/// Extracts the named argument array from a list of arguments, and returns it.
@@ -260,7 +260,7 @@ _checkAndCall(f, ftype, obj, typeArgs, args, name) => JS(
let originalTarget = obj === void 0 ? f : obj;
function callNSM() {
- return $noSuchMethod(originalTarget, new $InvocationImpl(
+ return $noSuchMethod(originalTarget, new $InvocationImpl.new(
$name, $args,
{namedArguments: $extractNamedArgs($args), isMethod: true}));
}

Powered by Google App Engine
This is Rietveld 408576698