Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2396)

Unified Diff: media/audio/audio_manager_base.cc

Issue 2934613002: Avoid shutdown crash if audio thread is hung. (Closed)
Patch Set: fixes recursive acquire Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/audio/audio_manager.cc ('K') | « media/audio/audio_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_manager_base.cc
diff --git a/media/audio/audio_manager_base.cc b/media/audio/audio_manager_base.cc
index 92a255d095cfb22ed58b36b766c22aa8084b2d58..72f9a336d73683251c5dedd9800b65d2c0b35d9c 100644
--- a/media/audio/audio_manager_base.cc
+++ b/media/audio/audio_manager_base.cc
@@ -98,9 +98,9 @@ AudioManagerBase::AudioManagerBase(std::unique_ptr<AudioThread> audio_thread,
AudioManagerBase::~AudioManagerBase() {
// All the output streams should have been deleted.
- CHECK_EQ(0, num_output_streams_);
+ DCHECK_EQ(0, num_output_streams_);
alokp 2017/06/13 23:35:51 Changing CHECKs in the constructor to DCHECKs sinc
DaleCurtis 2017/06/13 23:43:15 I think a better option would be to skip AM::Shutd
alokp 2017/06/14 17:34:35 Good idea. Done.
// All the input streams should have been deleted.
- CHECK(input_streams_.empty());
+ DCHECK(input_streams_.empty());
}
base::string16 AudioManagerBase::GetAudioInputDeviceModel() {
« media/audio/audio_manager.cc ('K') | « media/audio/audio_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698