recipe_modules/generator_script/api.py - Issue 2934583003: [step] Remove config indirection. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1133)

My Issues | Starred Open | Closed | All

Unified Diff: recipe_modules/generator_script/api.py

Issue 2934583003: [step] Remove config indirection. (Closed)

Patch Set: cleanup Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« recipe_engine/run.py ('K') | « recipe_engine/unittests/stream_test.py ('k') | recipe_modules/step/api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: recipe_modules/generator_script/api.py

diff --git a/recipe_modules/generator_script/api.py b/recipe_modules/generator_script/api.py

index 1cda3641477e7e5dba2b4bcdc17d46cb3207435e..067e8a42977fd31bd2ecf80bc44656580618f8ab 100644

--- a/recipe_modules/generator_script/api.py

+++ b/recipe_modules/generator_script/api.py

@@ -91,11 +91,11 @@ class GeneratorScriptApi(recipe_api.RecipeApi):

#TODO(martiniss) change this to use a regular step call

step['ok_ret'] = set(step.pop('ok_ret', {0}))

step['infra_step'] = bool(step.pop('infra_step', False))

- step['step_nest_level'] = step.pop('step_nest_level', 0)

+ step['nest_level'] = step.pop('step_nest_level', 0)

if step.pop('always_run', False) or not failed_steps:

try:

- self.m.step.run_from_dict(step)

+ self.m.step.run_step(**step)

iannucci 2017/06/12 18:20:08 this needs rebasing

except self.m.step.StepFailure:

failed_steps.append(step['name'])

finally:

« recipe_engine/run.py ('K') | « recipe_engine/unittests/stream_test.py ('k') | recipe_modules/step/api.py » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698