Sending a page load pingback to data saver for holdback users

chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h"
 
 #include <string>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/optional.h"
@@ skipping 129 matching lines @@
   // ResourceDispatcherHostDelegate::GetNavigationData during commit.
   // Because ChromeResourceDispatcherHostDelegate always returns a
   // ChromeNavigationData, it is safe to static_cast here.
   ChromeNavigationData* chrome_navigation_data =
       static_cast<ChromeNavigationData*>(
           navigation_handle->GetNavigationData());
   if (!chrome_navigation_data)
     return STOP_OBSERVING;
   data_reduction_proxy::DataReductionProxyData* data =
       chrome_navigation_data->GetDataReductionProxyData();
   if (!data || !data->used_data_reduction_proxy())

[tbansal1, 2017/06/09 22:32:55]

keep observing if holdback is enabled?

[RyanSturm, 2017/06/09 22:46:02]

?

This checks if DRP would have been used for the holdback case.

     return STOP_OBSERVING;
   data_ = data->DeepCopy();
   // DataReductionProxy page loads should only occur on HTTP navigations.
   DCHECK(!navigation_handle->GetURL().SchemeIsCryptographic());
+  DCHECK_EQ(data_->request_url(), navigation_handle->GetURL());
   return CONTINUE_OBSERVING;
 }
 
 page_load_metrics::PageLoadMetricsObserver::ObservePolicy
 DataReductionProxyMetricsObserver::OnStart(
     content::NavigationHandle* navigation_handle,
     const GURL& currently_committed_url,
     bool started_in_foreground) {
   if (!started_in_foreground)
     return STOP_OBSERVING;
@@ skipping 106 matching lines @@
 }
 
 void DataReductionProxyMetricsObserver::SendPingback(
     const page_load_metrics::mojom::PageLoadTiming& timing,
     const page_load_metrics::PageLoadExtraInfo& info,
     bool app_background_occurred) {
   // TODO(ryansturm): Move to OnFirstBackgroundEvent to handle some fast
   // shutdown cases. crbug.com/618072
   if (!browser_context_ || !data_)
     return;
-  if (data_reduction_proxy::params::IsIncludedInHoldbackFieldTrial() ||
-      data_reduction_proxy::params::IsIncludedInTamperDetectionExperiment()) {
-    return;
-  }
   // Only consider timing events that happened before the first background
   // event.
   base::Optional<base::TimeDelta> response_start;
   base::Optional<base::TimeDelta> load_event_start;
   base::Optional<base::TimeDelta> first_image_paint;
   base::Optional<base::TimeDelta> first_contentful_paint;
   base::Optional<base::TimeDelta> experimental_first_meaningful_paint;
   base::Optional<base::TimeDelta> parse_blocked_on_script_load_duration;
   base::Optional<base::TimeDelta> parse_stop;
   if (WasStartedInForegroundOptionalEventInForeground(timing.response_start,
@@ skipping 133 matching lines @@
     data_->set_lofi_received(true);
   }
   if (extra_request_complete_info.was_cached)
     return;
   original_network_bytes_ +=
       extra_request_complete_info.original_network_content_length;
   network_bytes_ += extra_request_complete_info.raw_body_bytes;
   num_network_resources_++;
   if (!extra_request_complete_info.data_reduction_proxy_data ||
       !extra_request_complete_info.data_reduction_proxy_data
            ->used_data_reduction_proxy()) {

[tbansal1, 2017/06/09 22:32:55]

check for holdback?

[RyanSturm, 2017/06/09 22:46:02]

This will track the number of requests that would have used DRP as is.

     return;
   }
   num_data_reduction_proxy_resources_++;
   network_bytes_proxied_ += extra_request_complete_info.raw_body_bytes;
 }
 
 DataReductionProxyPingbackClient*
 DataReductionProxyMetricsObserver::GetPingbackClient() const {
   return DataReductionProxyChromeSettingsFactory::GetForBrowserContext(
              browser_context_)
       ->data_reduction_proxy_service()
       ->pingback_client();
 }
 
 }  // namespace data_reduction_proxy