Changes in app.window and app.runtime to support lock screen note taking

apps/launcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/launcher.h"
 
 #include <memory>
 #include <set>
 #include <utility>
 
@@ skipping 19 matching lines @@
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/granted_file_entry.h"
 #include "extensions/browser/lazy_background_task_queue.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/common/api/app_runtime.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest_handlers/kiosk_mode_info.h"
+#include "extensions/common/permissions/api_permission.h"
+#include "extensions/common/permissions/permissions_data.h"
 #include "net/base/filename_util.h"
 #include "url/gurl.h"
 
 #if defined(OS_CHROMEOS)
 #include "components/user_manager/user_manager.h"
 #endif
 
 namespace app_runtime = extensions::api::app_runtime;
 
 using content::BrowserThread;
@@ skipping 377 matching lines @@
   scoped_refptr<PlatformAppPathLauncher> launcher =
       new PlatformAppPathLauncher(context, app, file_path);
   launcher->Launch();
 }
 
 void LaunchPlatformAppWithAction(
     content::BrowserContext* context,
     const extensions::Extension* app,
     std::unique_ptr<app_runtime::ActionData> action_data,
     const base::FilePath& file_path) {
+  if (action_data && action_data->is_lock_screen_action &&
+      *action_data->is_lock_screen_action &&
+      !app->permissions_data()->HasAPIPermission(
+          extensions::APIPermission::kLockScreen)) {
+    NOTREACHED() << "Launching lock screen action handler requires lockScreen "

[Devlin, 2017/06/14 19:13:47]

Why do we use NOTREACHED(); return; here instead of (D)CHECK?

[tbarzic, 2017/06/14 19:48:47]

I guess CHECK would be fine too.

+                 << "permission.";
+    return;
+  }
   scoped_refptr<PlatformAppPathLauncher> launcher =
       new PlatformAppPathLauncher(context, app, file_path);
   launcher->set_action_data(std::move(action_data));
   launcher->set_launch_source(extensions::AppLaunchSource::SOURCE_UNTRACKED);
   launcher->Launch();
 }
 
 void LaunchPlatformApp(content::BrowserContext* context,
                        const Extension* app,
                        extensions::AppLaunchSource source) {
@@ skipping 39 matching lines @@
 void LaunchPlatformAppWithUrl(content::BrowserContext* context,
                               const Extension* app,
                               const std::string& handler_id,
                               const GURL& url,
                               const GURL& referrer_url) {
   AppRuntimeEventRouter::DispatchOnLaunchedEventWithUrl(
       context, app, handler_id, url, referrer_url);
 }
 
 }  // namespace apps