chrome/test/data/safe_browsing/mach_o/Makefile - Issue 2934373002: Record Code Signature of Downloaded DMG files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/safe_browsing/mach_o/Makefile

Issue 2934373002: Record Code Signature of Downloaded DMG files (Closed)

Patch Set: addressing comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/safe_browsing/mach_o/Makefile

diff --git a/chrome/test/data/safe_browsing/mach_o/Makefile b/chrome/test/data/safe_browsing/mach_o/Makefile

index 199685ba4be827136bd1cbccc42a0a523b0cfa34..56da65ebc9cd1ea7c3e88f8d7d032a4385151596 100644

--- a/chrome/test/data/safe_browsing/mach_o/Makefile

+++ b/chrome/test/data/safe_browsing/mach_o/Makefile

@@ -58,6 +58,10 @@ signedexecutablefat: executablefat codesign.keychain

codesign -s $(KEYCHAIN_IDENTITY) --keychain $(PWD)/codesign.keychain \

$@ --all-architectures

+signed-archive.dmg: codesign.keychain

+ hdiutil create -srcfolder base-bundle.app -format UDZO -layout SPUD -volname "Signed Archive" -ov $@

+ codesign -f -s $(KEYCHAIN_IDENTITY) --keychain $(PWD)/codesign.keychain $@

.PHONY: test-bundle.app

test-bundle.app: signedexecutablefat libsigned64.dylib executable32

ditto base-bundle.app $@