Chromium Code Reviews Chromium Code Reviews
Issue 2934373002:
Record Code Signature of Downloaded DMG files (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index df5dbbca25f4e8a4e22639aef070f7db1411c1b4..fb7d0b85dfb42ef50db2599ed452261a9a6efcb1 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -22133,7 +22133,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <summary>Records the source that requested showing the feedback app.</summary> |
| </histogram> |
| -<histogram name="FileBrowser.ChangeDirectory.RootType" enum="FileManagerRootType"> |
| +<histogram name="FileBrowser.ChangeDirectory.RootType" |
| + enum="FileManagerRootType"> |
| <owner>yamaguchi@chromium.com</owner> |
| <summary> |
| Chrome OS File Browser: Counts the number of directory-changed events, |
| @@ -47870,14 +47871,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <owner>dimich@chromium.org</owner> |
| <summary> |
| Enum-based buckets reflect the number of days the Chrome was used in each |
| - specific way: |
| - - Not used at all during whole day. |
| - - Started, but failed to successfully navigate. |
| - - Only navigated to offline pages locally saved on the device. |
| - - Only navigated online. |
| - - Navigated to both online and offline pages. |
| - This data is accumulated locally and reported when connection is likely to |
| - succeed (usually after successful online navigation). |
| + specific way: - Not used at all during whole day. - Started, but failed to |
|
rkaplow
2017/06/30 20:31:40
if you're reformatting the text, this is a bit unr
mortonm
2017/06/30 20:54:04
Sorry, didn't notice the formatting tool went in a
|
| + successfully navigate. - Only navigated to offline pages locally saved on |
| + the device. - Only navigated online. - Navigated to both online and offline |
| + pages. This data is accumulated locally and reported when connection is |
| + likely to succeed (usually after successful online navigation). |
| </summary> |
| </histogram> |
| @@ -65065,6 +65063,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="SBClientDownload.DownloadFileHasDmgSignature" enum="Boolean"> |
| + <owner>jialiul@chromium.org</owner> |
| + <summary> |
| + Records whether a given download file is a cryptographically signed DMG |
|
rkaplow
2017/06/30 20:31:40
it is probably obvious for anyone looking, but mig
mortonm
2017/06/30 20:54:04
Done.
|
| + archive. This metric is logged before Chrome sends SafeBrowsing download |
| + pings. |
| + </summary> |
| +</histogram> |
| + |
| <histogram |
| name="SBClientDownload.DownloadFileWithoutDiskImageExtensionHasKolySignature" |
| enum="Boolean"> |
| @@ -80601,10 +80608,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <owner>sorin@chromium.org</owner> |
| <summary> |
| The number of download jobs found in the Windows BITS queue. This value is |
| - expected to be zero in most cases, or a small number otherwise. |
| - Large values indicate a problem with the job creation or clean up code. |
| - The metric is recorded before a new BITS job is created and inserted |
| - into BITS queue. |
| + expected to be zero in most cases, or a small number otherwise. Large values |
| + indicate a problem with the job creation or clean up code. The metric is |
| + recorded before a new BITS job is created and inserted into BITS queue. |
| </summary> |
| </histogram> |
