Record Code Signature of Downloaded DMG files

chrome/utility/safe_browsing/mac/dmg_iterator.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_UTILITY_SAFE_BROWSING_MAC_DMG_ITERATOR_H_
 #define CHROME_UTILITY_SAFE_BROWSING_MAC_DMG_ITERATOR_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 19 matching lines @@
   // of the stream.
   explicit DMGIterator(ReadStream* stream);
   ~DMGIterator();
 
   // Opens the DMG file for iteration. This must be called before any other
   // method. If this returns false, it is illegal to call any other methods
   // on this class. If this returns true, the iterator is advanced to an
   // invalid element before the first item.
   bool Open();
 
+  uint64_t GetDmgSignatureLength();
+
+  uint8_t* GetDmgSignatureData();

[Robert Sesek, 2017/06/26 18:56:33]

This method needs a comment.

[Robert Sesek, 2017/06/26 18:56:33]

naming: GetCodeSignature()

Using a vector will also clean up this interface into one method call.

[mortonm, 2017/06/27 16:36:23]

Done.

[mortonm, 2017/06/27 16:36:23]

Done.

+
   // Advances the iterator to the next file item. Returns true on success
   // and false on end-of-iterator.
   bool Next();
 
   // Returns the full path in a DMG filesystem to the current file item.
   base::string16 GetPath();
 
   // Returns a ReadStream for the current file item.
   std::unique_ptr<ReadStream> GetReadStream();
 
  private:
   UDIFParser udif_;  // The UDIF parser that accesses the partitions.
   // Streams for all the HFS partitions.
   std::vector<std::unique_ptr<ReadStream>> partitions_;
   size_t current_partition_;  // The index in |partitions_| of the current one.
   std::unique_ptr<HFSIterator>
       hfs_;  // The HFSIterator for |current_partition_|.
 
   DISALLOW_COPY_AND_ASSIGN(DMGIterator);
 };
 
 }  // namespace dmg
 }  // namespace safe_browsing
 
 #endif  // CHROME_UTILITY_SAFE_BROWSING_MAC_DMG_ITERATOR_H_