Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Unified Diff: chrome/browser/feedback/show_feedback_page.cc

Issue 2934303002: Provide a better way of injecting extra diagnostics in feedbacks (Closed)
Patch Set: pkasting's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/feedback/show_feedback_page.cc
diff --git a/chrome/browser/feedback/show_feedback_page.cc b/chrome/browser/feedback/show_feedback_page.cc
index b9967abe8ea74169a6bf856eacf238bb759d0f32..f2f9466711ed87e66818ec63c5e9a25a59e7bbe1 100644
--- a/chrome/browser/feedback/show_feedback_page.cc
+++ b/chrome/browser/feedback/show_feedback_page.cc
@@ -21,7 +21,8 @@ namespace chrome {
void ShowFeedbackPage(Browser* browser,
FeedbackSource source,
const std::string& description_template,
- const std::string& category_tag) {
+ const std::string& category_tag,
+ const std::string& extra_diagnostics) {
GURL page_url;
if (browser) {
page_url = GetTargetTabUrl(browser->session_id().id(),
@@ -47,7 +48,7 @@ void ShowFeedbackPage(Browser* browser,
extensions::FeedbackPrivateAPI::GetFactoryInstance()->Get(profile);
api->RequestFeedbackForFlow(
- description_template, category_tag, page_url,
+ description_template, category_tag, extra_diagnostics, page_url,
source == kFeedbackSourceSadTabPage
? feedback_private::FeedbackFlow::FEEDBACK_FLOW_SADTABCRASH
: feedback_private::FeedbackFlow::FEEDBACK_FLOW_REGULAR);

Powered by Google App Engine
This is Rietveld 408576698