chrome/browser/chromeos/login/ui/login_feedback.cc - Issue 2934303002: Provide a better way of injecting extra diagnostics in feedbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/login_feedback.cc

Issue 2934303002: Provide a better way of injecting extra diagnostics in feedbacks (Closed)

Patch Set: pkasting's comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/ui/login_feedback.cc

diff --git a/chrome/browser/chromeos/login/ui/login_feedback.cc b/chrome/browser/chromeos/login/ui/login_feedback.cc

index 6b216dff3dbd71ec152d2f6dd54e497dc134c1f0..3906002facca2b44b24f61eb9c5bf6be20ad2ef3 100644

--- a/chrome/browser/chromeos/login/ui/login_feedback.cc

+++ b/chrome/browser/chromeos/login/ui/login_feedback.cc

@@ -253,7 +253,7 @@ void LoginFeedback::EnsureFeedbackUI() {

extensions::FeedbackPrivateAPI* api =

extensions::FeedbackPrivateAPI::GetFactoryInstance()->Get(profile_);

api->RequestFeedbackForFlow(

- description_, "Login", GURL(),

+ description_, "Login", std::string(), GURL(),

extensions::api::feedback_private::FeedbackFlow::FEEDBACK_FLOW_LOGIN);

// Make sure there is a feedback app window opened.