Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Unified Diff: chrome/browser/ui/profile_error_dialog.cc

Issue 2934303002: Provide a better way of injecting extra diagnostics in feedbacks (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/profile_error_dialog.cc
diff --git a/chrome/browser/ui/profile_error_dialog.cc b/chrome/browser/ui/profile_error_dialog.cc
index ec3164897ae5a93f0dbf54feb9df97092064bec2..e6a63f0310d700339938015e7b31d99f247ca073 100644
--- a/chrome/browser/ui/profile_error_dialog.cc
+++ b/chrome/browser/ui/profile_error_dialog.cc
@@ -30,17 +30,10 @@ void OnProfileErrorDialogDismissed(const std::string& diagnostics,
std::string feedback_description =
l10n_util::GetStringUTF8(IDS_PROFILE_ERROR_FEEDBACK_DESCRIPTION);
- if (!diagnostics.empty()) {
- // TODO(afakhry): Add support to inject diagnostics to the feedback
- // reports without adding them to the description. crbug.com/708511.
- feedback_description +=
- "\n\n" +
- l10n_util::GetStringUTF8(IDS_PROFILE_ERROR_FEEDBACK_DIAGNOSTICS_LINE) +
- diagnostics;
- }
chrome::ShowFeedbackPage(nullptr, chrome::kFeedbackSourceProfileErrorDialog,
- feedback_description, kProfileErrorFeedbackCategory);
+ feedback_description, kProfileErrorFeedbackCategory,
+ diagnostics);
}
#endif // !defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698