Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2085)

Unified Diff: chrome/browser/chromeos/login/ui/login_feedback.cc

Issue 2934303002: Provide a better way of injecting extra diagnostics in feedbacks (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/login_feedback.cc
diff --git a/chrome/browser/chromeos/login/ui/login_feedback.cc b/chrome/browser/chromeos/login/ui/login_feedback.cc
index 6b216dff3dbd71ec152d2f6dd54e497dc134c1f0..5c6dd7b0b0c0ded0c8d1ab6fb529c0e7197f6801 100644
--- a/chrome/browser/chromeos/login/ui/login_feedback.cc
+++ b/chrome/browser/chromeos/login/ui/login_feedback.cc
@@ -253,7 +253,7 @@ void LoginFeedback::EnsureFeedbackUI() {
extensions::FeedbackPrivateAPI* api =
extensions::FeedbackPrivateAPI::GetFactoryInstance()->Get(profile_);
api->RequestFeedbackForFlow(
- description_, "Login", GURL(),
+ description_, "Login", std::string() /* extra_diagnostics */, GURL(),
Peter Kasting 2017/06/14 20:41:04 Nit: While there's no formal rule up or down on th
afakhry 2017/06/14 22:10:18 I kept them only in the code that was already usin
extensions::api::feedback_private::FeedbackFlow::FEEDBACK_FLOW_LOGIN);
// Make sure there is a feedback app window opened.

Powered by Google App Engine
This is Rietveld 408576698