Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Side by Side Diff: chrome/browser/ui/sad_tab.cc

Issue 2934303002: Provide a better way of injecting extra diagnostics in feedbacks (Closed)
Patch Set: pkasting's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/profile_error_dialog.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/sad_tab.h" 5 #include "chrome/browser/ui/sad_tab.h"
6 6
7 #include "base/metrics/histogram_macros.h" 7 #include "base/metrics/histogram_macros.h"
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "chrome/browser/net/referrer.h" 9 #include "chrome/browser/net/referrer.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 case Action::BUTTON: 224 case Action::BUTTON:
225 RecordEvent(show_feedback_button_, 225 RecordEvent(show_feedback_button_,
226 ui_metrics::SadTabEvent::BUTTON_CLICKED); 226 ui_metrics::SadTabEvent::BUTTON_CLICKED);
227 if (show_feedback_button_) { 227 if (show_feedback_button_) {
228 ShowFeedbackPage( 228 ShowFeedbackPage(
229 FindBrowserWithWebContents(web_contents_), 229 FindBrowserWithWebContents(web_contents_),
230 kFeedbackSourceSadTabPage, 230 kFeedbackSourceSadTabPage,
231 l10n_util::GetStringUTF8(kind_ == SAD_TAB_KIND_CRASHED 231 l10n_util::GetStringUTF8(kind_ == SAD_TAB_KIND_CRASHED
232 ? IDS_CRASHED_TAB_FEEDBACK_MESSAGE 232 ? IDS_CRASHED_TAB_FEEDBACK_MESSAGE
233 : IDS_KILLED_TAB_FEEDBACK_MESSAGE), 233 : IDS_KILLED_TAB_FEEDBACK_MESSAGE),
234 std::string(kCategoryTagCrash)); 234 std::string(kCategoryTagCrash), std::string());
235 } else { 235 } else {
236 web_contents_->GetController().Reload(content::ReloadType::NORMAL, 236 web_contents_->GetController().Reload(content::ReloadType::NORMAL,
237 true); 237 true);
238 } 238 }
239 break; 239 break;
240 case Action::HELP_LINK: 240 case Action::HELP_LINK:
241 RecordEvent(show_feedback_button_, 241 RecordEvent(show_feedback_button_,
242 ui_metrics::SadTabEvent::HELP_LINK_CLICKED); 242 ui_metrics::SadTabEvent::HELP_LINK_CLICKED);
243 content::OpenURLParams params(GURL(GetHelpLinkURL()), content::Referrer(), 243 content::OpenURLParams params(GURL(GetHelpLinkURL()), content::Referrer(),
244 WindowOpenDisposition::CURRENT_TAB, 244 WindowOpenDisposition::CURRENT_TAB,
(...skipping 27 matching lines...) Expand all
272 // Fall through 272 // Fall through
273 case chrome::SAD_TAB_KIND_KILLED: 273 case chrome::SAD_TAB_KIND_KILLED:
274 UMA_SAD_TAB_COUNTER("Tabs.SadTab.KillCreated"); 274 UMA_SAD_TAB_COUNTER("Tabs.SadTab.KillCreated");
275 LOG(WARNING) << "Tab Killed: " 275 LOG(WARNING) << "Tab Killed: "
276 << web_contents->GetURL().GetOrigin().spec(); 276 << web_contents->GetURL().GetOrigin().spec();
277 break; 277 break;
278 } 278 }
279 } 279 }
280 280
281 } // namespace chrome 281 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/profile_error_dialog.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698