Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/ui/chrome_pages.h

Issue 2934303002: Provide a better way of injecting extra diagnostics in feedbacks (Closed)
Patch Set: pkasting's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/profile_error_dialog.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_CHROME_PAGES_H_ 5 #ifndef CHROME_BROWSER_UI_CHROME_PAGES_H_
6 #define CHROME_BROWSER_UI_CHROME_PAGES_H_ 6 #define CHROME_BROWSER_UI_CHROME_PAGES_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 void ShowDownloads(Browser* browser); 59 void ShowDownloads(Browser* browser);
60 void ShowExtensions(Browser* browser, 60 void ShowExtensions(Browser* browser,
61 const std::string& extension_to_highlight); 61 const std::string& extension_to_highlight);
62 void ShowConflicts(Browser* browser); 62 void ShowConflicts(Browser* browser);
63 63
64 // ShowFeedbackPage() uses |browser| to determine the URL of the current tab. 64 // ShowFeedbackPage() uses |browser| to determine the URL of the current tab.
65 // |browser| should be NULL if there are no currently open browser windows. 65 // |browser| should be NULL if there are no currently open browser windows.
66 void ShowFeedbackPage(Browser* browser, 66 void ShowFeedbackPage(Browser* browser,
67 FeedbackSource source, 67 FeedbackSource source,
68 const std::string& description_template, 68 const std::string& description_template,
69 const std::string& category_tag); 69 const std::string& category_tag,
70 const std::string& extra_diagnostics);
70 71
71 void ShowHelp(Browser* browser, HelpSource source); 72 void ShowHelp(Browser* browser, HelpSource source);
72 void ShowHelpForProfile(Profile* profile, HelpSource source); 73 void ShowHelpForProfile(Profile* profile, HelpSource source);
73 void ShowBetaForum(Browser* browser); 74 void ShowBetaForum(Browser* browser);
74 void ShowPolicy(Browser* browser); 75 void ShowPolicy(Browser* browser);
75 void ShowSlow(Browser* browser); 76 void ShowSlow(Browser* browser);
76 77
77 // Constructs a settings GURL for the specified |sub_page|. 78 // Constructs a settings GURL for the specified |sub_page|.
78 GURL GetSettingsUrl(const std::string& sub_page); 79 GURL GetSettingsUrl(const std::string& sub_page);
79 80
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 114
114 // If the user is already signed in, shows the "Signin" portion of Settings, 115 // If the user is already signed in, shows the "Signin" portion of Settings,
115 // otherwise initiates signin in a new browser tab. 116 // otherwise initiates signin in a new browser tab.
116 void ShowBrowserSigninOrSettings(Browser* browser, 117 void ShowBrowserSigninOrSettings(Browser* browser,
117 signin_metrics::AccessPoint access_point); 118 signin_metrics::AccessPoint access_point);
118 #endif 119 #endif
119 120
120 } // namespace chrome 121 } // namespace chrome
121 122
122 #endif // CHROME_BROWSER_UI_CHROME_PAGES_H_ 123 #endif // CHROME_BROWSER_UI_CHROME_PAGES_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/profile_error_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698