Issue 2934243002: Move ie11 timeout handling code to BrowserControllerTestOutcome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2934243002: Move ie11 timeout handling code to BrowserControllerTestOutcome (Closed)

Created:
3 years, 6 months ago by Bill Hesse

Modified:
3 years, 6 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Move ie11 timeout handling code to BrowserControllerTestOutcome Only content_shell testing uses the BrowserCommandOutputImpl class. Rename the class to ContentShellCommandOutputImpl. BUG=https://github.com/dart-lang/sdk/issues/28955 BUG=https://github.com/dart-lang/sdk/issues/29869 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/e64ee959590a439bf0d5e3c9e609290535b70799

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -19 lines)			Patch
	M	tools/testing/dart/test_runner.dart	View	1	6 chunks	+15 lines, -19 lines	0 comments	Download

Total messages: 5 (2 generated)

Bill Hesse

3 years, 6 months ago (2017-06-14 13:50:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e64ee959590a439bf0d5e3c9e609290535b70799 (presubmit successful).