Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: Source/core/html/parser/HTMLParserIdioms.h

Issue 293423002: Refactor srcset parser to align it with spec changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added tests and fixed a bug Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/parser/HTMLParserIdioms.h
diff --git a/Source/core/html/parser/HTMLParserIdioms.h b/Source/core/html/parser/HTMLParserIdioms.h
index cd4fa9c11d4df6946ba5d5b34aec3d9cdc300d9c..40bdbaf7ecf642adbfac9eced401d17471edfdb4 100644
--- a/Source/core/html/parser/HTMLParserIdioms.h
+++ b/Source/core/html/parser/HTMLParserIdioms.h
@@ -36,11 +36,6 @@ class TextEncoding;
namespace WebCore {
-// Space characters as defined by the HTML specification.
-bool isHTMLSpace(UChar);
-bool isHTMLLineBreak(UChar);
-bool isNotHTMLSpace(UChar);
-
// Strip leading and trailing whitespace as defined by the HTML specification.
String stripLeadingAndTrailingHTMLSpaces(const String&);
template<size_t inlineCapacity>
@@ -69,8 +64,7 @@ typedef Vector<pair<String, String> > HTMLAttributeList;
// The returned encoding might not be valid.
WTF::TextEncoding encodingFromMetaAttributes(const HTMLAttributeList&);
-// Inline implementations of some of the functions declared above.
-
+// Space characters as defined by the HTML specification.
template<typename CharType>
inline bool isHTMLSpace(CharType character)
{
@@ -88,9 +82,15 @@ inline bool isHTMLSpace(CharType character)
}
template<typename CharType>
+inline bool isComma(CharType character)
eseidel 2014/05/28 22:24:59 inline is only a compiler hint and only has an eff
Yoav Weiss 2014/05/29 05:17:40 It's inline here since I also use it as a standalo
+{
+ return character == ',';
+}
+
+template<typename CharType>
inline bool isHTMLSpaceOrComma(CharType character)
{
- return isHTMLSpace<CharType>(character) || character == ',';
+ return isComma(character) || isHTMLSpace<CharType>(character);
}
inline bool isHTMLLineBreak(UChar character)

Powered by Google App Engine
This is Rietveld 408576698