Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: Source/core/html/HTMLImageElement.cpp

Issue 293423002: Refactor srcset parser to align it with spec changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added tests and fixed a bug Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserv ed. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserv ed.
5 * Copyright (C) 2010 Google Inc. All rights reserved. 5 * Copyright (C) 2010 Google Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 m_form->associate(*this); 151 m_form->associate(*this);
152 } else { 152 } else {
153 m_form = WeakPtr<HTMLFormElement>(); 153 m_form = WeakPtr<HTMLFormElement>();
154 } 154 }
155 } 155 }
156 156
157 void HTMLImageElement::setBestFitURLAndDPRFromImageCandidate(const ImageCandidat e& candidate) 157 void HTMLImageElement::setBestFitURLAndDPRFromImageCandidate(const ImageCandidat e& candidate)
158 { 158 {
159 m_bestFitImageURL = candidate.url(); 159 m_bestFitImageURL = candidate.url();
160 m_currentSrc = AtomicString(document().completeURL(imageSourceURL()).string( )); 160 m_currentSrc = AtomicString(document().completeURL(imageSourceURL()).string( ));
161 float candidateScaleFactor = candidate.scaleFactor(); 161 float candidateDensity = candidate.density();
162 // FIXME: Make this ">0" part match the spec, once it settles. 162 // FIXME: Make this ">0" part match the spec, once it settles.
163 if (candidateScaleFactor > 0) 163 if (candidateDensity > 0)
164 m_imageDevicePixelRatio = 1 / candidateScaleFactor; 164 m_imageDevicePixelRatio = 1 / candidateDensity;
165 if (renderer() && renderer()->isImage()) 165 if (renderer() && renderer()->isImage())
166 toRenderImage(renderer())->setImageDevicePixelRatio(m_imageDevicePixelRa tio); 166 toRenderImage(renderer())->setImageDevicePixelRatio(m_imageDevicePixelRa tio);
167 } 167 }
168 168
169 void HTMLImageElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value) 169 void HTMLImageElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value)
170 { 170 {
171 if (name == altAttr) { 171 if (name == altAttr) {
172 if (renderer() && renderer()->isImage()) 172 if (renderer() && renderer()->isImage())
173 toRenderImage(renderer())->updateAltText(); 173 toRenderImage(renderer())->updateAltText();
174 } else if (name == srcAttr || name == srcsetAttr || name == sizesAttr) { 174 } else if (name == srcAttr || name == srcsetAttr || name == sizesAttr) {
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 if (!image) 537 if (!image)
538 return FloatSize(); 538 return FloatSize();
539 LayoutSize size; 539 LayoutSize size;
540 size = image->imageSizeForRenderer(renderer(), 1.0f); // FIXME: Not sure abo ut this. 540 size = image->imageSizeForRenderer(renderer(), 1.0f); // FIXME: Not sure abo ut this.
541 if (renderer() && renderer()->isRenderImage() && image->image() && !image->i mage()->hasRelativeWidth()) 541 if (renderer() && renderer()->isRenderImage() && image->image() && !image->i mage()->hasRelativeWidth())
542 size.scale(toRenderImage(renderer())->imageDevicePixelRatio()); 542 size.scale(toRenderImage(renderer())->imageDevicePixelRatio());
543 return size; 543 return size;
544 } 544 }
545 545
546 } 546 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698