LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src.html - Issue 293423002: Refactor srcset parser to align it with spec changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src.html

Issue 293423002: Refactor srcset parser to align it with spec changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added tests and fixed a bug Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt ('k') | LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src-expected.txt » ('j') | Source/core/html/parser/HTMLParserIdioms.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <html>

2 <head>

3 <script src="resources/srcset-helper.js"></script>

4 <script src="../../resources/js-test.js"></script>

5 <script>

6 if (window.testRunner) {

7 testRunner.dumpAsText();

8 }

9

10 addEventListener("load", function() {

11 shouldBeTrue('document.getElementById("foo").clientWidth==400');

12 }, false);

13 </script>

14 </head>

15

16 <body id="body">

17 <div>This test passes if this img tag below is a green square regardless of the scale factor. It ensures that invalid inputs

18 from srcset are ignored, and src is selected (since it's the only candidate left)</div>

19 <img id="foo" src="resources/green-400-px-square.png" srcset="1x 5z, , , resources/blue-100-px-square.png 2px, 2x 3h,,">

20 </body>

21 </html>

OLD	NEW