LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html - Issue 293423002: Refactor srcset parser to align it with spec changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html

Issue 293423002: Refactor srcset parser to align it with spec changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed ASSERT Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLImageElement/image-picture-1x.html ('k') | LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 window.targetScaleFactor = 1;	4 window.targetScaleFactor = 1;

5 </script>	5 </script>

6 <script src="resources/srcset-helper.js"></script>	6 <script src="resources/srcset-helper.js"></script>

7 <script src="../../resources/js-test.js"></script>	7 <script src="../../resources/js-test.js"></script>

8 <script>	8 <script>

9 addEventListener("load", function() {	9 addEventListener("load", function() {

10 shouldBeTrue('document.getElementById("foo").clientWidth==100');	10 shouldBeTrue('document.getElementById("foo").clientWidth==100');

11 shouldBeTrue('document.getElementById("foo2").clientWidth==200');	11 shouldBeTrue('document.getElementById("foo2").clientWidth==100');

12 }, false);	12 }, false);

13 </script>	13 </script>

14 </head>	14 </head>

15	15

16 <body id="body">	16 <body id="body">

17 <div>This test passes if the image below is a 100px blue square when the dev iceScaleFactor is 1.</div>	17 <div>This test passes if the image below is a 100px blue square when the dev iceScaleFactor is 1.</div>

18 <div> It tests that even though the 1x resource contains many invalid descri ptors,	18 <div> It tests that even though the 1x resource contains many invalid descri ptors,

19 only the invalid descriptors are ignored (according to the spec).</div>	19 only the invalid descriptors are ignored (according to the spec).</div>

20 <img id="foo" src="" srcset="resources/blue-100-px-square.png 43q 1x dfs 3dd , resources/green-400-px-square.png 2x">	20 <img id="foo" src="" srcset="resources/blue-100-px-square.png 43q 1x dfs 3dd , resources/green-400-px-square.png 2x">

21 <img id="foo2" src="" srcset="resources/blue-100-px-square.png 300q, resourc es/green-400-px-square.png 2x">	21 <img id="foo2" src="" srcset="resources/blue-100-px-square.png 300q, resourc es/green-400-px-square.png 2x">

22 </body>	22 </body>

23 </html>	23 </html>

OLD	NEW