Refactor srcset parser to align it with spec changes

Source/core/html/parser/HTMLSrcsetParser.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef HTMLSrcsetParser_h
 #define HTMLSrcsetParser_h
 
 #include "wtf/text/WTFString.h"
 
 namespace WebCore {
 
-struct DescriptorParsingResult {
-    float scaleFactor;
-    int resourceWidth;
-
+class DescriptorParsingResult {

[eseidel, 2014/05/29 06:59:53]

Much nicer, thanks.

+public:
     DescriptorParsingResult()
+        : m_density(-1.0)
+        , m_resourceWidth(-1)
+        , m_resourceHeight(-1)
     {
-        scaleFactor = -1.0;
-        resourceWidth = -1;
     }
 
-    bool foundDescriptor() const
-    {
-        return (scaleFactor >= 0 || resourceWidth >= 0);
-    }
+    bool hasDensity() { return m_density >= 0; }
+    bool hasWidth() { return m_resourceWidth >= 0; }
+    bool hasHeight() { return m_resourceHeight >= 0; }
+
+    float density() const { ASSERT(hasDensity()); return m_density; }
+    unsigned resourceWidth() const { ASSERT(hasWidth()); return m_resourceWidth; }
+    unsigned resourceHeight() const { ASSERT(hasHeight()); return m_resourceHeight; }
+
+    void setResourceWidth(int width) { ASSERT(width >= 0); m_resourceWidth = (unsigned)width; }
+    void setResourceHeight(int height) { ASSERT(height >= 0); m_resourceHeight = (unsigned)height; }
+    void setDensity(float densityToSet) { ASSERT(densityToSet >= 0); m_density = densityToSet; }
+
+private:
+    float m_density;
+    int m_resourceWidth;
+    int m_resourceHeight;
 };
 
 class ImageCandidate {
 public:
     enum OriginAttribute {
         SrcsetOrigin,
         SrcOrigin
     };
 
     ImageCandidate()
-        : m_scaleFactor(1.0)
+        : m_density(1.0)
     {
     }
 
     ImageCandidate(const String& source, unsigned start, unsigned length, const DescriptorParsingResult& result, OriginAttribute originAttribute)
         : m_string(source.createView(start, length))
-        , m_scaleFactor(result.scaleFactor)
-        , m_resourceWidth(result.resourceWidth)
+        , m_density(result.density())
+        , m_resourceWidth(result.resourceWidth())
         , m_originAttribute(originAttribute)
     {
     }
 
     String toString() const
     {
         return String(m_string.toString());
     }
 
     AtomicString url() const
     {
         return AtomicString(m_string.toString());
     }
 
-    void setScaleFactor(float factor)
+    void setDensity(float factor)
     {
-        m_scaleFactor = factor;
+        m_density = factor;
     }
 
-    float scaleFactor() const
+    float density() const
     {
-        return m_scaleFactor;
+        return m_density;
     }
 
     int resourceWidth() const
     {
         return m_resourceWidth;
     }
 
     bool srcOrigin() const
     {
         return (m_originAttribute == SrcOrigin);
     }
 
     inline bool isEmpty() const
     {
         return m_string.isEmpty();
     }
 
 private:
     StringView m_string;
-    float m_scaleFactor;
+    float m_density;
     int m_resourceWidth;
     OriginAttribute m_originAttribute;
 };
 
 ImageCandidate bestFitSourceForSrcsetAttribute(float deviceScaleFactor, unsigned sourceSize, const String& srcsetAttribute);
 
 ImageCandidate bestFitSourceForImageAttributes(float deviceScaleFactor, unsigned sourceSize, const String& srcAttribute, const String& srcsetAttribute);
 
 String bestFitSourceForImageAttributes(float deviceScaleFactor, unsigned sourceSize, const String& srcAttribute, ImageCandidate& srcsetImageCandidate);
 
 }
 
 #endif