Delete the logPrivate APIs

chrome/browser/extensions/api/log_private/log_private_api.h

Index: chrome/browser/extensions/api/log_private/log_private_api.h
diff --git a/chrome/browser/extensions/api/log_private/log_private_api.h b/chrome/browser/extensions/api/log_private/log_private_api.h
deleted file mode 100644
index d413e463fb07133b7ddacfc9dbfa0c3a9fa22c48..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/api/log_private/log_private_api.h
+++ /dev/null
@@ -1,207 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_EXTENSIONS_API_LOG_PRIVATE_LOG_PRIVATE_API_H_
-#define CHROME_BROWSER_EXTENSIONS_API_LOG_PRIVATE_LOG_PRIVATE_API_H_
-
-#include <set>
-#include <string>
-
-#include "base/files/scoped_file.h"
-#include "base/macros.h"
-#include "base/scoped_observer.h"
-#include "chrome/browser/extensions/api/log_private/filter_handler.h"
-#include "chrome/browser/extensions/api/log_private/log_parser.h"
-#include "chrome/browser/extensions/chrome_extension_function.h"
-#include "chrome/browser/feedback/system_logs/system_logs_fetcher.h"
-#include "chrome/common/extensions/api/log_private.h"
-#include "extensions/browser/api/api_resource.h"
-#include "extensions/browser/api/api_resource_manager.h"
-#include "extensions/browser/browser_context_keyed_api_factory.h"
-#include "extensions/browser/extension_registry_observer.h"
-#include "net/log/net_log.h"
-#include "net/log/write_to_file_net_log_observer.h"
-
-class IOThread;
-
-namespace content {
-class BrowserContext;
-}
-
-namespace extensions {
-class ExtensionRegistry;
-
-// Tracked log files.
-class FileResource : public ApiResource {
- public:
-  FileResource(const std::string& owner_extension_id,
-               const base::FilePath& path);
-  ~FileResource() override;
-
-  // ApiResource overrides.
-  bool IsPersistent() const override;
-
-  static const char kSequenceToken[];
-  static const base::SequencedWorkerPool::WorkerShutdown kShutdownBehavior =
-      base::SequencedWorkerPool::BLOCK_SHUTDOWN;
-
- private:
-  base::FilePath path_;
-
-  DISALLOW_COPY_AND_ASSIGN(FileResource);
-};
-
-class LogPrivateAPI : public BrowserContextKeyedAPI,
-                      public ExtensionRegistryObserver,
-                      public net::NetLog::ThreadSafeObserver {
- public:
-  // Convenience method to get the LogPrivateAPI for a profile.
-  static LogPrivateAPI* Get(content::BrowserContext* context);
-
-  explicit LogPrivateAPI(content::BrowserContext* context);
-  ~LogPrivateAPI() override;
-
-  void StartNetInternalsWatch(const std::string& extension_id,
-                              api::log_private::EventSink event_sink,
-                              const base::Closure& closure);
-  void StopNetInternalsWatch(const std::string& extension_id,
-                             const base::Closure& closure);
-  void StopAllWatches(const std::string& extension_id,
-                      const base::Closure& closure);
-  void RegisterTempFile(const std::string& owner_extension_id,
-                        const base::FilePath& file_path);
-
-  // BrowserContextKeyedAPI implementation.
-  static BrowserContextKeyedAPIFactory<LogPrivateAPI>* GetFactoryInstance();
-
- private:
-  friend class BrowserContextKeyedAPIFactory<LogPrivateAPI>;
-
-  void Initialize();
-
-  void RegisterTempFileOnFileResourceSequence(
-      const std::string& owner_extension_id,
-      const base::FilePath& file_path);
-
-  // ExtensionRegistryObserver implementation.
-  void OnExtensionUnloaded(content::BrowserContext* browser_context,
-                           const Extension* extension,
-                           UnloadedExtensionReason reason) override;
-
-  // NetLog::ThreadSafeObserver implementation:
-  void OnAddEntry(const net::NetLogEntry& entry) override;
-
-  void PostPendingEntries();
-  void AddEntriesOnUI(std::unique_ptr<base::ListValue> value);
-
-  // Creates a file that will be written to by net::WriteToFileNetLogObserver.
-  void CreateTempNetLogFile(const std::string& owner_extension_id,
-                            base::ScopedFILE* file);
-
-  // Starts observing network events with a new |net_logger| instance.
-  void StartObservingNetEvents(IOThread* io_thread, base::ScopedFILE* file);
-  void MaybeStartNetInternalLogging(const std::string& caller_extension_id,
-                                    IOThread* io_thread,
-                                    api::log_private::EventSink event_sink);
-  void MaybeStopNetInternalLogging(const base::Closure& closure);
-  void StopNetInternalLogging();
-
-  // BrowserContextKeyedAPI implementation.
-  static const char* service_name() {
-    return "LogPrivateAPI";
-  }
-  static const bool kServiceIsNULLWhileTesting = true;
-  static const bool kServiceRedirectedInIncognito = true;
-
-  content::BrowserContext* const browser_context_;
-  bool logging_net_internals_;
-  api::log_private::EventSink event_sink_;
-  std::set<std::string> net_internal_watches_;
-  std::unique_ptr<base::ListValue> pending_entries_;
-  std::unique_ptr<net::WriteToFileNetLogObserver> write_to_file_observer_;
-  // Listen to extension unloaded notifications.
-  ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
-      extension_registry_observer_;
-  ApiResourceManager<FileResource, WorkerPoolThreadTraits<FileResource> >
-      log_file_resources_;
-  bool initialized_;
-
-  DISALLOW_COPY_AND_ASSIGN(LogPrivateAPI);
-};
-
-class LogPrivateGetHistoricalFunction : public AsyncExtensionFunction {
- public:
-  LogPrivateGetHistoricalFunction();
-  DECLARE_EXTENSION_FUNCTION("logPrivate.getHistorical",
-                             LOGPRIVATE_GETHISTORICAL);
-
- protected:
-  ~LogPrivateGetHistoricalFunction() override;
-  bool RunAsync() override;
-
- private:
-  void OnSystemLogsLoaded(
-      std::unique_ptr<system_logs::SystemLogsResponse> sys_info);
-
-  std::unique_ptr<FilterHandler> filter_handler_;
-
-  DISALLOW_COPY_AND_ASSIGN(LogPrivateGetHistoricalFunction);
-};
-
-class LogPrivateStartEventRecorderFunction : public AsyncExtensionFunction {
- public:
-  LogPrivateStartEventRecorderFunction();
-  DECLARE_EXTENSION_FUNCTION("logPrivate.startEventRecorder",
-                             LOGPRIVATE_STARTEVENTRECODER);

[tbarzic, 2017/06/15 01:46:05]

LOGPRIVATE_ enums to DELETED_LOGPRIVATE_
but it might be clearer to do it in a follow up :)

[afakhry, 2017/06/15 17:00:00]

Can we do it in this CL? That way if we need to revert for some reason, we
revert everything together.

Also, I have a question. Should we remove those instances too?:

-
https://cs.chromium.org/chromium/src/chrome/common/extensions/docs/server2/te...


-
https://cs.chromium.org/chromium/src/chrome/common/extensions/docs/server2/kn...

-
https://cs.chromium.org/chromium/src/chrome/common/extensions/api/_permission...

-
https://cs.chromium.org/chromium/src/chrome/common/extensions/api/_api_featur...

[Lei Zhang, 2017/06/15 17:20:15]

Sure.
Not sure. You can always ask Devlin.

[afakhry, 2017/06/15 17:39:01]

+Devlin for my above question.

[Devlin, 2017/06/15 17:54:31]

Yep, I think these can all be deleted.

-
- protected:
-  ~LogPrivateStartEventRecorderFunction() override;
-  bool RunAsync() override;
-
- private:
-  void OnEventRecorderStarted();
-
-  DISALLOW_COPY_AND_ASSIGN(LogPrivateStartEventRecorderFunction);
-};
-
-class LogPrivateStopEventRecorderFunction : public AsyncExtensionFunction {
- public:
-  LogPrivateStopEventRecorderFunction();
-  DECLARE_EXTENSION_FUNCTION("logPrivate.stopEventRecorder",
-                             LOGPRIVATE_STOPEVENTRECODER);
-
- protected:
-  ~LogPrivateStopEventRecorderFunction() override;
-
-  // AsyncExtensionFunction overrides.
-  bool RunAsync() override;
-
- private:
-  void OnEventRecorderStopped();
-
-  DISALLOW_COPY_AND_ASSIGN(LogPrivateStopEventRecorderFunction);
-};
-
-class LogPrivateDumpLogsFunction : public AsyncExtensionFunction {
- public:
-  LogPrivateDumpLogsFunction();
-  DECLARE_EXTENSION_FUNCTION("logPrivate.dumpLogs", LOGPRIVATE_DUMPLOGS);
-
- protected:
-  ~LogPrivateDumpLogsFunction() override;
-
-  // AsyncExtensionFunction overrides.
-  bool RunAsync() override;
-
- private:
-  // Callback for DebugLogWriter::StoreLogs() call.
-  void OnStoreLogsCompleted(const base::FilePath& log_path, bool succeeded);
-  // Callback for LogPrivateAPI::StopAllWatches() call.
-  void OnStopAllWatches();
-  DISALLOW_COPY_AND_ASSIGN(LogPrivateDumpLogsFunction);
-};
-
-}  // namespace extensions
-
-#endif  // CHROME_BROWSER_EXTENSIONS_API_LOG_PRIVATE_LOG_PRIVATE_API_H_