Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 2934163002: Delete the logPrivate APIs (Closed)
Patch Set: Devlin's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 737 matching lines...) Expand 10 before | Expand all | Expand 10 after
748 skip.insert(APIPermission::kDownloadsShelf); 748 skip.insert(APIPermission::kDownloadsShelf);
749 skip.insert(APIPermission::kEmbeddedExtensionOptions); 749 skip.insert(APIPermission::kEmbeddedExtensionOptions);
750 skip.insert(APIPermission::kExtensionView); 750 skip.insert(APIPermission::kExtensionView);
751 skip.insert(APIPermission::kFontSettings); 751 skip.insert(APIPermission::kFontSettings);
752 skip.insert(APIPermission::kFullscreen); 752 skip.insert(APIPermission::kFullscreen);
753 skip.insert(APIPermission::kGcm); 753 skip.insert(APIPermission::kGcm);
754 skip.insert(APIPermission::kIdle); 754 skip.insert(APIPermission::kIdle);
755 skip.insert(APIPermission::kImeWindowEnabled); 755 skip.insert(APIPermission::kImeWindowEnabled);
756 skip.insert(APIPermission::kInlineInstallPrivate); 756 skip.insert(APIPermission::kInlineInstallPrivate);
757 skip.insert(APIPermission::kIdltest); 757 skip.insert(APIPermission::kIdltest);
758 skip.insert(APIPermission::kLogPrivate); 758 skip.insert(APIPermission::kDeletedLogPrivate);
Devlin 2017/06/15 19:17:37 ditto
afakhry 2017/06/15 19:26:50 Done.
759 skip.insert(APIPermission::kOverrideEscFullscreen); 759 skip.insert(APIPermission::kOverrideEscFullscreen);
760 skip.insert(APIPermission::kPointerLock); 760 skip.insert(APIPermission::kPointerLock);
761 skip.insert(APIPermission::kPower); 761 skip.insert(APIPermission::kPower);
762 skip.insert(APIPermission::kPrinterProvider); 762 skip.insert(APIPermission::kPrinterProvider);
763 skip.insert(APIPermission::kSessions); 763 skip.insert(APIPermission::kSessions);
764 skip.insert(APIPermission::kStorage); 764 skip.insert(APIPermission::kStorage);
765 skip.insert(APIPermission::kSystemCpu); 765 skip.insert(APIPermission::kSystemCpu);
766 skip.insert(APIPermission::kSystemDisplay); 766 skip.insert(APIPermission::kSystemDisplay);
767 skip.insert(APIPermission::kSystemMemory); 767 skip.insert(APIPermission::kSystemMemory);
768 skip.insert(APIPermission::kSystemNetwork); 768 skip.insert(APIPermission::kSystemNetwork);
(...skipping 999 matching lines...) Expand 10 before | Expand all | Expand 10 after
1768 scoped_refptr<Extension> extension_dwr( 1768 scoped_refptr<Extension> extension_dwr(
1769 LoadManifest("permissions", "web_request_all_host_permissions.json")); 1769 LoadManifest("permissions", "web_request_all_host_permissions.json"));
1770 const PermissionSet& permissions_dwr = 1770 const PermissionSet& permissions_dwr =
1771 extension_dwr->permissions_data()->active_permissions(); 1771 extension_dwr->permissions_data()->active_permissions();
1772 1772
1773 EXPECT_FALSE(PermissionMessageProvider::Get()->IsPrivilegeIncrease( 1773 EXPECT_FALSE(PermissionMessageProvider::Get()->IsPrivilegeIncrease(
1774 permissions, permissions_dwr, extension->GetType())); 1774 permissions, permissions_dwr, extension->GetType()));
1775 } 1775 }
1776 1776
1777 } // namespace extensions 1777 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698