Change to accommade Angular plugin and finalize removal of dependency to analysis_server

pkg/analyzer_plugin/lib/utilities/completion/inherited_reference_contributor.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
@@ skipping 26 matching lines @@
         new CompletionTarget.forOffset(request.result.unit, request.offset);
     OpType optype = new OpType.forCompletion(target, request.offset);
     if (!optype.includeIdentifiers) {
       return;
     }
     ClassDeclaration classDecl = _enclosingClass(target);
     if (classDecl == null || classDecl.element == null) {
       return;
     }
     containingLibrary = request.result.libraryElement;
-    _computeSuggestionsForClass2(
-        collector,
-        target,
-        resolutionMap.elementDeclaredByClassDeclaration(classDecl),
-        request,
-        optype);
+    _computeSuggestionsForClass2(collector, target,
+        resolutionMap.elementDeclaredByClassDeclaration(classDecl), optype);
+  }
+
+  Future<Null> computeSuggestionsForClass(

[mfairhurst, 2017/06/13 20:31:39]

Could use a comment that this is here for our use case (and similar ones)

[maxkim, 2017/06/13 20:49:22]

Acknowledged.

[Brian Wilkerson, 2017/06/13 20:50:19]

Is this a short-term work-around until you can just add this contributor
directly, or is this intended to be a long-term addition to the public API? In
either case, yes, it needs to be documented.

[maxkim, 2017/06/13 21:11:40]

This is intended to be long-term and I'll write up an API documentation.

+    CompletionRequest request,
+    CompletionCollector collector,
+    ClassElement classElement, {
+    AstNode entryPoint,
+    bool skipChildClass,
+    OpType optype,
+  }) async {
+    CompletionTarget target = new CompletionTarget.forOffset(

[mfairhurst, 2017/06/13 20:31:39]

I would assume that we would want to pass in a CompletionTarget rather than have
it figure out its own completion target

[maxkim, 2017/06/13 20:49:22]

Acknowledged.

+        request.result.unit, request.offset,
+        entryPoint: entryPoint);
+    optype ??= new OpType.forCompletion(target, request.offset);
+    if (!optype.includeIdentifiers) {
+      return;
+    }
+    if (classElement == null) {
+      ClassDeclaration classDecl = _enclosingClass(target);
+      if (classDecl == null || classDecl.element == null) {
+        return;
+      }
+      classElement = resolutionMap.elementDeclaredByClassDeclaration(classDecl);
+    }
+    containingLibrary = request.result.libraryElement;
+    _computeSuggestionsForClass2(collector, target, classElement, optype,
+        skipChildClass: skipChildClass);
   }
 
   _addSuggestionsForType(InterfaceType type, OpType optype,
       {bool isFunctionalArgument: false}) {
     if (!isFunctionalArgument) {
       for (PropertyAccessorElement elem in type.accessors) {
         if (elem.isGetter) {
           if (optype.includeReturnValueSuggestions) {
             addSuggestion(elem);
           }
@@ skipping 12 matching lines @@
           addSuggestion(elem);
         }
       } else {
         if (optype.includeVoidReturnSuggestions) {
           addSuggestion(elem);
         }
       }
     }
   }
 
-  void _computeSuggestionsForClass2(
-      CompletionCollector collector,
-      CompletionTarget target,
-      ClassElement classElement,
-      CompletionRequest request,
-      OpType optype,
+  void _computeSuggestionsForClass2(CompletionCollector collector,
+      CompletionTarget target, ClassElement classElement, OpType optype,
       {bool skipChildClass: true}) {
     bool isFunctionalArgument = target.isFunctionalArgument();
     kind = isFunctionalArgument
         ? CompletionSuggestionKind.IDENTIFIER
         : CompletionSuggestionKind.INVOCATION;
 
     if (!skipChildClass) {
       _addSuggestionsForType(classElement.type, optype,
           isFunctionalArgument: isFunctionalArgument);
     }
@@ skipping 26 matching lines @@
       if (node is FieldDeclaration) {
         if (node.isStatic) {
           return null;
         }
       }
       node = node.parent;
     }
     return null;
   }
 }