chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc - Issue 2934043002: Use ContainsValue() instead of std::find() in chrome/browser/chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc

Issue 2934043002: Use ContainsValue() instead of std::find() in chrome/browser/chromeos (Closed)

Patch Set: Fixed compilation error. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/gfx_utils_unittest.cc ('k') | chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc b/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc

index d38cf288a3f6112aed53a9c59d2bf552573c830c..3161294371913cdb369c6a34f43c49d02960ad51 100644

--- a/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc

+++ b/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h"

#include "base/memory/ptr_util.h"

+#include "base/stl_util.h"

#include "chrome/browser/chromeos/login/quick_unlock/quick_unlock_factory.h"

#include "chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.h"

#include "chrome/browser/chromeos/profiles/profile_helper.h"

@@ -66,7 +67,7 @@ bool AreModesEqual(const QuickUnlockModeList& a, const QuickUnlockModeList& b) {

// This is a slow comparison algorithm, but the number of entries in |a| and

// |b| will always be very low (0-3 items) so it doesn't matter.

for (size_t i = 0; i < a.size(); ++i) {

- if (std::find(b.begin(), b.end(), a[i]) == b.end())

+ if (!base::ContainsValue(b, a[i]))

return false;

}