Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 293403010: [NaCl SDK] Fix include_next of stdlib.h (Closed)

Created:
6 years, 7 months ago by binji
Modified:
6 years, 7 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org
Visibility:
Public.

Description

[NaCl SDK] Fix include_next of stdlib.h This change moves include_next outside of the include guard. On PNaCl, including <stdlib.h> will include usr/include/stdlib.h. Naclports copies this file to toolchain/linux_pnacl/usr/local/include/stdlib.h, which will be included next. Since it uses the same include guard, the real stdlib.h won't be included. This change fixes the linux SDK builder: voronoi.cc:48:37: error: use of undeclared identifier 'rand_r' return static_cast<unsigned char>(rand_r(&g_rand_state) & 255); ^ BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M native_client_sdk/src/libraries/nacl_io/include/stdlib.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
6 years, 7 months ago (2014-05-27 23:01:34 UTC) #1
Sam Clegg
LGTM. This is kinda of a mess. I hope we can improve on this later.
6 years, 7 months ago (2014-05-27 23:12:05 UTC) #2
binji
On 2014/05/27 23:12:05, Sam Clegg wrote: > LGTM. > > This is kinda of a ...
6 years, 7 months ago (2014-05-27 23:15:42 UTC) #3
Sam Clegg
On 2014/05/27 23:15:42, binji wrote: > On 2014/05/27 23:12:05, Sam Clegg wrote: > > LGTM. ...
6 years, 7 months ago (2014-05-27 23:22:41 UTC) #4
binji
On 2014/05/27 23:22:41, Sam Clegg wrote: > On 2014/05/27 23:15:42, binji wrote: > > On ...
6 years, 7 months ago (2014-05-27 23:49:25 UTC) #5
binji
6 years, 7 months ago (2014-05-27 23:51:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r273075 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698