Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: runtime/vm/compiler.cc

Issue 293403009: Remove unused code, improve speed of Parser::CurrentToken (improvement seen in measurements and pro… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/parser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
===================================================================
--- runtime/vm/compiler.cc (revision 36705)
+++ runtime/vm/compiler.cc (working copy)
@@ -240,21 +240,6 @@
}
-static void InstallUnoptimizedCode(const Function& function) {
- // Disable optimized code.
- ASSERT(function.HasOptimizedCode());
- if (FLAG_trace_compiler) {
- OS::Print("--> patching entry %#" Px "\n",
- Code::Handle(function.CurrentCode()).EntryPoint());
- }
- function.SwitchToUnoptimizedCode();
- if (FLAG_trace_compiler) {
- OS::Print("--> restoring entry at %#" Px "\n",
- Code::Handle(function.unoptimized_code()).EntryPoint());
- }
-}
-
-
// Return false if bailed out.
static bool CompileParsedFunctionHelper(ParsedFunction* parsed_function,
bool optimized,
@@ -772,13 +757,6 @@
Isolate* isolate = Isolate::Current();
StackZone zone(isolate);
LongJumpScope jump;
- // Make sure unoptimized code is not collected while we are compiling.
- const Code& unoptimized_code = Code::ZoneHandle(function.unoptimized_code());
- // Skips parsing if we need to only install unoptimized code.
- if (!optimized && !unoptimized_code.IsNull()) {
- InstallUnoptimizedCode(function);
- return Error::null();
- }
if (setjmp(*jump.Set()) == 0) {
TIMERSCOPE(isolate, time_compilation);
Timer per_compile_timer(FLAG_trace_compiler, "Compilation time");
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | runtime/vm/parser.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698