Pepper: FileDownloader cleanup.

Pepper: FileDownloader cleanup.

More cleaning up of unused code in FileDownloader.

BUG=239656
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273417

[dmichael (off chromium), 2014-05-28 20:20:19]

lgtm

https://codereview.chromium.org/293403008/diff/40001/ppapi/native_client/src/...
File ppapi/native_client/src/trusted/plugin/file_downloader.cc (right):

https://codereview.chromium.org/293403008/diff/40001/ppapi/native_client/src/...
ppapi/native_client/src/trusted/plugin/file_downloader.cc:24: :
instance_(instance),
nit: indentation looks off

https://codereview.chromium.org/293403008/diff/40001/ppapi/native_client/src/...
File ppapi/native_client/src/trusted/plugin/file_downloader.h (right):

https://codereview.chromium.org/293403008/diff/40001/ppapi/native_client/src/...
ppapi/native_client/src/trusted/plugin/file_downloader.h:38:
FileDownloader(Plugin* instance);
nit: explicit

[teravest, 2014-05-28 20:22:28]

The CQ bit was checked by teravest@chromium.org

[teravest, 2014-05-28 20:22:44]

thanks!

On Wed, May 28, 2014 at 2:20 PM,  <dmichael@chromium.org> wrote:
> lgtm
>
>
>
>
>
https://codereview.chromium.org/293403008/diff/40001/ppapi/native_client/src/...
> File ppapi/native_client/src/trusted/plugin/file_downloader.cc (right):
>
>
https://codereview.chromium.org/293403008/diff/40001/ppapi/native_client/src/...
> ppapi/native_client/src/trusted/plugin/file_downloader.cc:24: :
> instance_(instance),
> nit: indentation looks off

done.

>
>
https://codereview.chromium.org/293403008/diff/40001/ppapi/native_client/src/...
> File ppapi/native_client/src/trusted/plugin/file_downloader.h (right):
>
>
https://codereview.chromium.org/293403008/diff/40001/ppapi/native_client/src/...
> ppapi/native_client/src/trusted/plugin/file_downloader.h:38:
> FileDownloader(Plugin* instance);
> nit: explicit

done.

>
> https://codereview.chromium.org/293403008/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-05-28 20:22:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/teravest@chromium.org/293403008/60001

[commit-bot: I haz the power, 2014-05-28 23:38:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-05-29 00:22:33]

Change committed as 273417

[Finnur, 2014-06-02 22:09:20]

https://codereview.chromium.org/293403008/diff/60001/ppapi/native_client/src/...
File ppapi/native_client/src/trusted/plugin/file_downloader.h (left):

https://codereview.chromium.org/293403008/diff/60001/ppapi/native_client/src/...
ppapi/native_client/src/trusted/plugin/file_downloader.h:133: int32_t
status_code_;
Shouldn't we initialize this in the ctor?

[teravest, 2014-06-03 14:28:07]

On 2014/06/02 22:09:20, Finnur wrote:
>
https://codereview.chromium.org/293403008/diff/60001/ppapi/native_client/src/...
> File ppapi/native_client/src/trusted/plugin/file_downloader.h (left):
> 
>
https://codereview.chromium.org/293403008/diff/60001/ppapi/native_client/src/...
> ppapi/native_client/src/trusted/plugin/file_downloader.h:133: int32_t
> status_code_;
> Shouldn't we initialize this in the ctor?

I guess that'd be a bit cleaner, though it doesn't matter much. This class is
going away soon anyway.