Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Chromium Code Reviews
Help
|
Chromium Project
|
Sign in
(279)
Issues
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
2934018
: Take out temporary code now that WebKit plugin change is rolled. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by
jam
Modified:
4 years ago
Reviewers:
darin (slow to review)
,
brettw
CC:
chromium-reviews, brettw-cc_chromium.org
Base URL:
svn://chrome-svn/chrome/trunk/src/
Visibility:
Public.
Description
Take out temporary code now that WebKit plugin change is rolled. Committed:
http://src.chromium.org/viewvc/chrome?view=rev&revision=52355
Patch Set 1 : ''
#
Created:
4 years, 10 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+0 lines, -45 lines
)
Patch
M
chrome/renderer/render_view.cc
View
1 chunk
+0 lines, -6 lines
0 comments
Download
M
webkit/glue/plugins/pepper_webplugin_impl.h
View
1 chunk
+0 lines, -7 lines
0 comments
Download
M
webkit/glue/plugins/pepper_webplugin_impl.cc
View
1 chunk
+0 lines, -12 lines
0 comments
Download
M
webkit/glue/plugins/webplugin_impl.h
View
1 chunk
+0 lines, -7 lines
0 comments
Download
M
webkit/glue/plugins/webplugin_impl.cc
View
2 chunks
+0 lines, -13 lines
0 comments
Download
Trybot results:
mac
linux
win
More>>>
<<<Less
Commit:
CQ not working?
Messages
Total messages: 4 (0 generated)
Expand Messages
|
Collapse Messages
jam
4 years, 10 months ago (2010-07-14 18:01:52 UTC)
#1
Sign in
to reply to this message.
brettw
LGTM
4 years, 10 months ago (2010-07-14 18:18:07 UTC)
#2
LGTM
Sign in
to reply to this message.
darin (slow to review)
LGTM2
4 years, 10 months ago (2010-07-14 18:38:37 UTC)
#3
LGTM2
Sign in
to reply to this message.
darin (slow to review)
LGTM2
4 years, 10 months ago (2010-07-14 18:38:38 UTC)
#4
LGTM2
Sign in
to reply to this message.
Expand Messages
|
Collapse Messages
Issue 2934018: Take out temporary code now that WebKit plugin change is rolled. (Closed)
Created 4 years, 10 months ago by jam
Modified 4 years ago
Reviewers: darin (slow to review), brettw
Base URL: svn://chrome-svn/chrome/trunk/src/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
ec887be