Add local results details pages.

build/android/pylib/instrumentation/instrumentation_test_instance.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import logging
 import os
 import pickle
 import re
 
@@ skipping 470 matching lines @@
     self._initializeTestControlAttributes(args)
 
     self._coverage_directory = None
     self._initializeTestCoverageAttributes(args)
 
     self._store_tombstones = False
     self._symbolizer = None
     self._initializeTombstonesAttributes(args)
 
     self._gs_results_bucket = None
-    self._should_save_logcat = None
     self._initializeLogAttributes(args)
 
     self._edit_shared_prefs = []
     self._initializeEditPrefsAttributes(args)
 
     self._replace_system_package = None
     self._initializeReplaceSystemPackageAttributes(args)
 
     self._external_shard_index = args.test_launcher_shard_index
     self._total_external_shards = args.test_launcher_total_shards
@@ skipping 165 matching lines @@
     self._coverage_directory = args.coverage_dir
 
   def _initializeTombstonesAttributes(self, args):
     self._store_tombstones = args.store_tombstones
     self._symbolizer = stack_symbolizer.Symbolizer(
         self.apk_under_test.path if self.apk_under_test else None,
         args.enable_relocation_packing)
 
   def _initializeLogAttributes(self, args):
     self._gs_results_bucket = args.gs_results_bucket
-    self._should_save_logcat = bool(args.json_results_file)
 
   def _initializeEditPrefsAttributes(self, args):
     if not hasattr(args, 'shared_prefs_file') or not args.shared_prefs_file:
       return
     if not isinstance(args.shared_prefs_file, str):
       logging.warning("Given non-string for a filepath")
       return
     self._edit_shared_prefs = shared_preference_utils.ExtractSettingsFromJson(
         args.shared_prefs_file)
 
@@ skipping 49 matching lines @@
 
   @property
   def junit3_runner_class(self):
     return self._junit3_runner_class
 
   @property
   def junit4_runner_class(self):
     return self._junit4_runner_class
 
   @property
-  def should_save_logcat(self):
-    return self._should_save_logcat
-
-  @property
   def package_info(self):
     return self._package_info
 
   @property
   def render_results_dir(self):
     return self._render_results_dir
 
   @property
   def replace_system_package(self):
     return self._replace_system_package
@@ skipping 134 matching lines @@
 
   @staticmethod
   def GenerateTestResults(
       result_code, result_bundle, statuses, start_ms, duration_ms):
     return GenerateTestResults(result_code, result_bundle, statuses,
                                start_ms, duration_ms)
 
   #override
   def TearDown(self):
     self.symbolizer.CleanUp()