Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm

Issue 2933963002: [ios] Fix omnibox baseWritingDirection and dismissal iOS11 bugs. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
diff --git a/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm b/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
index 1180cf6b75987b1c03cfa0e5866ef4cccc57d712..1d47dbd32c0bd51ca1c7b91908f24382e816bc1d 100644
--- a/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
+++ b/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
@@ -554,7 +554,7 @@ NSString* const kOmniboxFadeAnimationKey = @"OmniboxFadeAnimation";
return;
}
- NSTextAlignment alignment = [self bestTextAlignment];
+ NSTextAlignment alignment = [self bestAlignmentForText:[self text]];
rohitrao (ping after 24h) 2017/06/12 22:08:52 Why is it ok to always use [self text] here? Is t
[self setTextAlignment:alignment];
UITextWritingDirection writingDirection =
alignment == NSTextAlignmentLeft ? UITextWritingDirectionLeftToRight
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698