Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: chrome/browser/metrics/metrics_services_manager.cc

Issue 293393010: Move initial metrics gathering tasks out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_services_manager.cc
diff --git a/chrome/browser/metrics/metrics_services_manager.cc b/chrome/browser/metrics/metrics_services_manager.cc
index 7a6295b7c04b13b00e09fcbebe733f93d3b92109..4ea1d453dfbb460755cd017668d7432475fe1f24 100644
--- a/chrome/browser/metrics/metrics_services_manager.cc
+++ b/chrome/browser/metrics/metrics_services_manager.cc
@@ -7,7 +7,6 @@
#include "base/command_line.h"
#include "base/prefs/pref_service.h"
#include "chrome/browser/metrics/chrome_metrics_service_client.h"
-#include "chrome/browser/metrics/extensions_metrics_provider.h"
#include "chrome/browser/metrics/metrics_service.h"
#include "chrome/browser/metrics/metrics_state_manager.h"
#include "chrome/browser/metrics/variations/variations_service.h"
@@ -29,15 +28,7 @@ MetricsServicesManager::~MetricsServicesManager() {
MetricsService* MetricsServicesManager::GetMetricsService() {
DCHECK(thread_checker_.CalledOnValidThread());
- if (!metrics_service_client_) {
- metrics_service_client_ =
- ChromeMetricsServiceClient::Create(GetMetricsStateManager(),
- local_state_);
- metrics_service_client_->metrics_service()->RegisterMetricsProvider(
- scoped_ptr<metrics::MetricsProvider>(
- new ExtensionsMetricsProvider(GetMetricsStateManager())));
- }
- return metrics_service_client_->metrics_service();
+ return GetChromeMetricsServiceClient()->metrics_service();
}
rappor::RapporService* MetricsServicesManager::GetRapporService() {
@@ -60,7 +51,17 @@ MetricsServicesManager::GetVariationsService() {
void MetricsServicesManager::OnPluginLoadingError(
const base::FilePath& plugin_path) {
- GetMetricsService()->LogPluginLoadingError(plugin_path);
+ GetChromeMetricsServiceClient()->LogPluginLoadingError(plugin_path);
+}
+
+ChromeMetricsServiceClient*
+MetricsServicesManager::GetChromeMetricsServiceClient() {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ if (!metrics_service_client_) {
+ metrics_service_client_ = ChromeMetricsServiceClient::Create(
+ GetMetricsStateManager(), local_state_);
+ }
+ return metrics_service_client_.get();
}
metrics::MetricsStateManager* MetricsServicesManager::GetMetricsStateManager() {

Powered by Google App Engine
This is Rietveld 408576698