chrome/browser/metrics/metrics_services_manager.cc - Issue 293393010: Move initial metrics gathering tasks out of MetricsService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_services_manager.cc

Issue 293393010: Move initial metrics gathering tasks out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/chrome_metrics_service_client.cc ('K') | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/browser/prefs/browser_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_services_manager.cc

diff --git a/chrome/browser/metrics/metrics_services_manager.cc b/chrome/browser/metrics/metrics_services_manager.cc

index 7a6295b7c04b13b00e09fcbebe733f93d3b92109..7ce689e73800c70ac2d9e9a716be63575671034e 100644

--- a/chrome/browser/metrics/metrics_services_manager.cc

+++ b/chrome/browser/metrics/metrics_services_manager.cc

@@ -60,7 +60,9 @@ MetricsServicesManager::GetVariationsService() {

void MetricsServicesManager::OnPluginLoadingError(

const base::FilePath& plugin_path) {

- GetMetricsService()->LogPluginLoadingError(plugin_path);

+ if (!metrics_service_client_)

+ GetMetricsService();

Alexei Svitkine (slow) 2014/06/02 13:54:03 Nit: Instead, create a private GetMetricsServiceCl

blundell 2014/06/02 14:24:46 Done.

+ metrics_service_client_->LogPluginLoadingError(plugin_path);

}

metrics::MetricsStateManager* MetricsServicesManager::GetMetricsStateManager() {

« chrome/browser/metrics/chrome_metrics_service_client.cc ('K') | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/browser/prefs/browser_prefs.cc » ('j') | no next file with comments »